Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

[LIVE-1911] Feature - Add collection name resolver to eth familly #4899

Merged
merged 10 commits into from
Apr 7, 2022
Merged

[LIVE-1911] Feature - Add collection name resolver to eth familly #4899

merged 10 commits into from
Apr 7, 2022

Conversation

lambertkevin
Copy link
Contributor

Dependency

LedgerHQ/ledger-live-common#1863

🦒 Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-1911

💻 Description / Demo (image or video)

Before

Screenshot 2022-04-06 at 23 19 24

After

Screenshot 2022-04-06 at 23 07 28

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

@lambertkevin lambertkevin requested review from a team as code owners April 6, 2022 21:20
@lambertkevin lambertkevin changed the base branch from develop to release/2.41.x April 6, 2022 21:20
@lambertkevin lambertkevin added the dependencies Pull requests that update a dependency file label Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Thanks for your contribution.
To be groomed for next release, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements 8.74% 9/103
🔴 Branches 0% 0/19
🔴 Functions 2.94% 1/34
🔴 Lines 8.33% 8/96

Test suite run success

1 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 829b481

@lambertkevin lambertkevin force-pushed the feat/add-collection-name-resolver-to-eth-familly branch from 829b481 to 8d9a9af Compare April 6, 2022 21:56
@lambertkevin
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Generating new screenshots

@lambertkevin lambertkevin force-pushed the feat/add-collection-name-resolver-to-eth-familly branch from 8d9a9af to df6b483 Compare April 7, 2022 11:26
@lambertkevin lambertkevin force-pushed the feat/add-collection-name-resolver-to-eth-familly branch from df6b483 to 9a28ed0 Compare April 7, 2022 12:21
@lambertkevin lambertkevin force-pushed the feat/add-collection-name-resolver-to-eth-familly branch from 9a28ed0 to 550d6b1 Compare April 7, 2022 15:46
@lambertkevin lambertkevin merged commit 0fa9086 into release/2.41.x Apr 7, 2022
@lambertkevin lambertkevin deleted the feat/add-collection-name-resolver-to-eth-familly branch April 7, 2022 18:58
lambertkevin added a commit that referenced this pull request Apr 7, 2022
@lambertkevin @ledgerlive
[LIVE-1911] Feature - Add collection name resolver to eth familly (#4899
0228d44 
)

* Bump temp LLC dependency

* update screenshots (windows)

* update screenshots (linux)

* Fix NFT transaction summary error (#4898)

* v2.41.0

* run ci

* Add LLC dependency

* Add nftResolvers to bridge proxy

* Add useNftCollectionName everywhere

Co-authored-by: Team Live <[email protected]>
lambertkevin added a commit that referenced this pull request Apr 7, 2022
@lambertkevin @ledgerlive
[LIVE-1911] Feature - Add collection name resolver to eth familly (#4899
9038073 
)

* Bump temp LLC dependency

* update screenshots (windows)

* update screenshots (linux)

* Fix NFT transaction summary error (#4898)

* v2.41.0

* run ci

* Add LLC dependency

* Add nftResolvers to bridge proxy

* Add useNftCollectionName everywhere

Co-authored-by: Team Live <[email protected]>
@lambertkevin lambertkevin mentioned this pull request Apr 7, 2022
Merged
lambertkevin added a commit that referenced this pull request Apr 11, 2022
@lambertkevin @ledgerlive
[LIVE-1911] Feature - Add collection name resolver to eth familly (#4899
270ddc3 
)

* Bump temp LLC dependency

* update screenshots (windows)

* update screenshots (linux)

* Fix NFT transaction summary error (#4898)

* v2.41.0

* run ci

* Add LLC dependency

* Add nftResolvers to bridge proxy

* Add useNftCollectionName everywhere

Co-authored-by: Team Live <[email protected]>
lambertkevin added a commit that referenced this pull request Apr 11, 2022
@lambertkevin @ledgerlive
[LIVE-1911] Feature - Add collection name resolver to eth familly (#4899
3a96a90 
)

* Bump temp LLC dependency

* update screenshots (windows)

* update screenshots (linux)

* Fix NFT transaction summary error (#4898)

* v2.41.0

* run ci

* Add LLC dependency

* Add nftResolvers to bridge proxy

* Add useNftCollectionName everywhere

Co-authored-by: Team Live <[email protected]>
lambertkevin added a commit that referenced this pull request Apr 12, 2022
@lambertkevin @ledgerlive
[LIVE-1911] Feature - Add collection name resolver to eth familly (#4899
6117c65 
)

* Bump temp LLC dependency

* update screenshots (windows)

* update screenshots (linux)

* Fix NFT transaction summary error (#4898)

* v2.41.0

* run ci

* Add LLC dependency

* Add nftResolvers to bridge proxy

* Add useNftCollectionName everywhere

Co-authored-by: Team Live <[email protected]>
lambertkevin added a commit that referenced this pull request Apr 20, 2022
@lambertkevin @ledgerlive
[LIVE-1911] Feature - Add collection name resolver to eth familly (#4899
4b24973 
)

* Bump temp LLC dependency

* update screenshots (windows)

* update screenshots (linux)

* Fix NFT transaction summary error (#4898)

* v2.41.0

* run ci

* Add LLC dependency

* Add nftResolvers to bridge proxy

* Add useNftCollectionName everywhere

Co-authored-by: Team Live <[email protected]>
valpinkman added a commit that referenced this pull request May 3, 2022
@valpinkman
Merge branch 'release/2.41.x'
c2ce96d 
* release/2.41.x: (56 commits)
  v2.41.3
  Fix NFT send making the app crash in prod (again) (#4958)
  v2.41.2
  Update to LLC 22.0.3
  FIX LIVE-2186 - Fix NFT crashing the app on send (#4953)
  Remove @ledgerhq/ledger-core again after bad merge (#4951)
  Update to temp LLC dependency + @LedgerHQ libs
  FIX LIVE-2176 - Fix NFT Crumb (#4950)
  v2.41.1
  Update LLC dependency
  LIVE-2080 Fixing Flowtype issues being wrongly ignored (#4938)
  v2.41.0
  update screenshots (windows)
  update screenshots (linux)
  New Crowdin updates (#4913)
  Add LLC#22.0.1 dependency
  Update links to use the new explorer from metadata (#4912)
  Bugfix: Solana linting (#4902)
  [LIVE-1911] Feature - Add collection name resolver to eth familly (#4899)
  LIVE-1751 Solana staking (#4884)
  ...
valpinkman added a commit that referenced this pull request May 3, 2022
@valpinkman
Merge branch 'release/2.41.x' into develop
1d0dfc3 
* release/2.41.x: (31 commits)
  v2.41.3
  Fix NFT send making the app crash in prod (again) (#4958)
  v2.41.2
  Update to LLC 22.0.3
  FIX LIVE-2186 - Fix NFT crashing the app on send (#4953)
  Remove @ledgerhq/ledger-core again after bad merge (#4951)
  Update to temp LLC dependency + @LedgerHQ libs
  FIX LIVE-2176 - Fix NFT Crumb (#4950)
  v2.41.1
  Update LLC dependency
  LIVE-2080 Fixing Flowtype issues being wrongly ignored (#4938)
  v2.41.0
  update screenshots (windows)
  update screenshots (linux)
  New Crowdin updates (#4913)
  Add LLC#22.0.1 dependency
  Update links to use the new explorer from metadata (#4912)
  Bugfix: Solana linting (#4902)
  [LIVE-1911] Feature - Add collection name resolver to eth familly (#4899)
  LIVE-1751 Solana staking (#4884)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thomasrogerlux thomasrogerlux thomasrogerlux approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lambertkevin @thomasrogerlux @ledgerlive