This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Remove @ledgerhq/ledger-core again after bad merge #4951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
force-pushed
the
support/remove-libcore-dependency
branch
from
000f1af
to
d945c4b
Compare
valpinkman
approved these changes
Apr 28, 2022
ghost
marked this pull request as ready for review
Merged
valpinkman
added a commit
that referenced
this pull request
May 3, 2022
* release/2.41.x: (56 commits) v2.41.3 Fix NFT send making the app crash in prod (again) (#4958) v2.41.2 Update to LLC 22.0.3 FIX LIVE-2186 - Fix NFT crashing the app on send (#4953) Remove @ledgerhq/ledger-core again after bad merge (#4951) Update to temp LLC dependency + @LedgerHQ libs FIX LIVE-2176 - Fix NFT Crumb (#4950) v2.41.1 Update LLC dependency LIVE-2080 Fixing Flowtype issues being wrongly ignored (#4938) v2.41.0 update screenshots (windows) update screenshots (linux) New Crowdin updates (#4913) Add LLC#22.0.1 dependency Update links to use the new explorer from metadata (#4912) Bugfix: Solana linting (#4902) [LIVE-1911] Feature - Add collection name resolver to eth familly (#4899) LIVE-1751 Solana staking (#4884) ...
valpinkman
added a commit
that referenced
this pull request
May 3, 2022
* release/2.41.x: (31 commits) v2.41.3 Fix NFT send making the app crash in prod (again) (#4958) v2.41.2 Update to LLC 22.0.3 FIX LIVE-2186 - Fix NFT crashing the app on send (#4953) Remove @ledgerhq/ledger-core again after bad merge (#4951) Update to temp LLC dependency + @LedgerHQ libs FIX LIVE-2176 - Fix NFT Crumb (#4950) v2.41.1 Update LLC dependency LIVE-2080 Fixing Flowtype issues being wrongly ignored (#4938) v2.41.0 update screenshots (windows) update screenshots (linux) New Crowdin updates (#4913) Add LLC#22.0.1 dependency Update links to use the new explorer from metadata (#4912) Bugfix: Solana linting (#4902) [LIVE-1911] Feature - Add collection name resolver to eth familly (#4899) LIVE-1751 Solana staking (#4884) ...
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦒 Context (issues, jira)
@ledgerhq/ledger-corewas initially removed by #4867 but somehow reappeared probably after some bad merge.💻 Description / Demo (image or video)
This PR just removes it again.
🖤 Expectations to reach
PR must pass CI, rebase develop if conflicts. Thanks!