Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LocalImageView. #258

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Adding LocalImageView. #258

merged 5 commits into from
Apr 16, 2024

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Apr 16, 2024

Comment on lines 7 to 9
local_image: LocalImage;
local_user: LocalUser;
person: Person;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including both local user and person in the response?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its needed for the join anyway, but this is autogenerated from the back-end.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it from the back-end now.

@dessalines dessalines marked this pull request as draft April 16, 2024 12:49
@dessalines dessalines marked this pull request as ready for review April 16, 2024 12:57
@SleeplessOne1917 SleeplessOne1917 merged commit d53af8c into main Apr 16, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the create_local_image_view branch April 16, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants