Creating a LocalImageView, so that front ends have the Person struct. #4631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
requested review from
Nutomic,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
This was referenced Apr 16, 2024
|
This should only be necessary for the admin endpoint |
|
I'd rather not add two separate media types returned, especially since the front end uses a component that works for both, and uses the same type. @SleeplessOne1917 suggested that I could remove the |
Nutomic
reviewed
Apr 16, 2024
| @@ -71,7 +71,7 @@ test("Upload image and delete it", async () => { | |||
|
|
|||
| // The deleteUrl is a combination of the endpoint, delete token, and alias | |||
| let firstImage = listMediaRes.images[0]; | |||
| let deleteUrl = `${alphaUrl}/pictrs/image/delete/${firstImage.pictrs_delete_token}/${firstImage.pictrs_alias}`; | |||
| let deleteUrl = `${alphaUrl}/pictrs/image/delete/${firstImage.local_image.pictrs_delete_token}/${firstImage.local_image.pictrs_alias}`; | |||
There was a problem hiding this comment.
Add some asserts here to ensure the correct person is returned. Otherwise looks fine.
|
|
Nutomic
approved these changes
Apr 16, 2024
SleeplessOne1917
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
local_user_idwasn't enough for lemmy-ui to show the person listing, and link to the uploader.The linked lemmy-ui PR below has a video of how this looks in action.