Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding image upload views for admins and profiles. #2424

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Apr 16, 2024

Description

Adds the ability to view and delete media uploads for admins and users

Screenshots

Screen_Recording_20240415_214719_Fulguris.mp4

context: LemmyNet/lemmy#4631

Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and both the admin and personal image views get stuck on an infinite loading screen. Looking at the network tab, the request succeeds. The local view pages are also blank after a refresh or directly navigating there.

@dessalines
Copy link
Member Author

The blank pages are gonna be tough to figure out, bc I can't replicate. I just tested again, and the linked video above shows a refresh. It might be because this requires an unmerged back-end change that's running with my new LocalImageView . I'll leave this as draft until the back-end gets merged.

@dessalines dessalines marked this pull request as draft April 16, 2024 13:54
@dessalines dessalines marked this pull request as ready for review April 17, 2024 00:36
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it again and it works.

@SleeplessOne1917 SleeplessOne1917 merged commit 9dcaff4 into main Apr 17, 2024
2 checks passed
@SleeplessOne1917 SleeplessOne1917 deleted the list_media branch April 17, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants