Update from original repository #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously using Bearer Authorization instead of Basic. Previously, the call did not seem to result in actual deletions, whereas after the switch there were multiple deletions.
In production, expired UUIDs may return as a 404 instead of a 401. This expands the condition for refreshing access tokens to include a 404. No Remote test is added because sending a bad UUID seems to trigger a 500 from the sandbox instead of the 404 we see in prod. Remote: 17 tests, 43 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 23 tests, 105 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: In order to support Network Tokens this commit adds the supportability in the add_cart method and supports_network_tokenization? method is setted in true. Closes activemerchant#4608 Unit Test: Finished in 0.256649 seconds. 43 tests, 188 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Test: Finished in 24.736933 seconds. 38 tests, 102 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 750 files inspected, no offenses detected
A temporary fix to enable NTID generation for cards without an NTID before the Nov 1 Visa deadline CER-234
ECS-2655 The IPG gateway requires a `store_id` to be used as part of the authentication. This value is correlates to a given merchant and is currently saved on the gateway initalize. By saving it only then, it prevents merchants with submerchants from using this gateway. This commit adds a new optional field that will override the saved `store_id` with one passed in for that merchant. Test Summary Remote: 18 tests, 54 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Description ------------------------- Adding support in Adyen gateway to append level 2 and level 3 information that provides commercial shoppers with additional information about purchases on their card statements. Closes activemerchant#4617 Unit test ------------------------- Finished in 0.117629 seconds. 103 tests, 522 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 139.349852 seconds. 127 tests, 423 assertions, 14 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 88.9764% passed Rubocop ------------------------- 750 files inspected, no offenses detected
Kosovo's XK country code is considered invalid by Adyen, but the Adyen API will accept QZ as a valid value to represent Kosovo instead CER-266
CER-243 This PR refactors the order of some methods to prevent XML parse errors. It also adds support for the following fields: installment_gracePeriodDuration taxManagementIndicator purchaseTotals_invoiceAmount purchaseTotals_originalAmount invoiceHeader_referenceDataCode invoiceHeader_invoiceNumber ccCaptureService_gratuityAmount ccAuthService_mobileRemotePaymentType otherTax_vatTaxRate Local: 5371 tests, 76705 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 118 tests, 600 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.6102% passed There is one additional remote test failure due to the fields not being added at the top level. Unit: 123 tests, 588 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: ------------------------------ Adding Reach gateway with authorize, purchase and capture calls, also small correction on the CardStream local test to complain with Rubocop warnings. Remote Test: ------------------------------ Finished in 6.627757 seconds. 7 tests, 14 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ 5365 tests, 76686 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 753 files inspected, no offenses detected
Orbital adapter is currently failing certification based on missing support for these changes. Adds: - Support for commercial echeck (BankAccountType = 'X') - Support for Discover 3DS (DigitalTokenCryptogram) Unit: 144 tests, 817 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 122 tests, 509 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ECS-2144
* Reach: adding gateway Summary: ------------------------------ Adding Reach gateway with authorize, purchase and capture calls, also small correction on the CardStream local test to complain with Rubocop warnings. Remote Test: ------------------------------ Finished in 6.627757 seconds. 7 tests, 14 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ 5365 tests, 76686 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 753 files inspected, no offenses detected * Reach: Add customs fields ## Summary: Adding Reach custom fields Remote tests -------------------------------------------------------------------------- 12 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed unit tests -------------------------------------------------------------------------- 11 tests, 40 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Co-authored-by: cristian <[email protected]>
Unit: 16 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 22 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Integrate apple pay in payeezy implementation along with tests. [Payeezy DPAN implementation](https://developer.payeezy.com/payeezy-api/apis/post/transactions-7) which is akin to our `NetworkTokenizationCreditCard` object SER-336 Rubocop: 750 files inspected, no offenses detected Unit: 43 tests, 201 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 42 tests, 172 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Scrub the `xid` and `cavv` values from the transcript. Additional scrub for `cvv`. SER-336 Unit: 44 tests, 203 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 43 tests, 174 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: ------------------------------ In order to scrub fields in the transaction transript, this commit adds fields to be filtered. Remote Test: ------------------------------ Finished in 10.189499 seconds. 7 tests, 18 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Test: ------------------------------ 6 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: ------------------------------ 753 files inspected, no offenses detected Co-authored-by: Gustavo Sanmartin <[email protected]>
This PR updates a few methods so that fields can be sent independently without causing the method to return if certain fields aren’t present. It also updates the order in which some methods are added to the request re: the XSD file. Unit Tests: 124 tests, 592 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 119 tests, 605 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 95.7983% passed *There are 3 tests that have been failing for months and a few others that are failing intermittently associated with bank accounts. I tried to look and see if maybe just the response message had changed but the failures are unpredictable and sometimes pass, while another bank account test fails. Local: 5399 tests, 76829 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
fix tests Closes activemerchant#4629
Description ------------------------- The authorization_secret_key GSF is set to be only sent on auth purchase transactions (the default), but this field is used for authenticating transactions and should be passed for every transaction type. auth key field is added to transactions that do not currently include it the remote test was updated due to outdated test card numbers Closes activemerchant#4635 Unit test ------------------------- Finished in 0.029899 seconds. 32 tests, 164 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 30.504306 seconds. 41 tests, 91 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 85.3659% passed Rubocop ------------------------- 753 files inspected, 11 offenses detected, 11 offenses corrected
This reverts commit 77d6e0b. Local Tests 5399 tests, 76828 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests 123 tests, 588 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Tests 118 tests, 602 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.4576% passed *same 3 are failing on master
Added new gateway `commerce_hub` along with remote and unit tests. This integration includes support for `stored_credential` fields along with basic gateway transactions, except for `capture`. `capture` is currently not in a working state due to unknown configuration issues with our test account. In order to unblock this integration, I have left the transaction method in the gateway class and opted to comment out the test. CommerceHub is working to enable our test account for `capture` transactions, and once completed, we can re-test the transaction type. We also encounter a number of rate limit issues with our remote tests, which leads to some of the test failures. SER-207 Unit: 9 tests, 78 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 753 files inspected, no offenses detected Remote: 15 tests, 30 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 66.6667% passed
Description ------------------------- This integration support the following payment operations: Verify Void Refund Unit test ------------------------- Finished in 40.346607 seconds. 5370 tests, 76698 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 133.10 tests/s, 1900.98 assertions/s Remote test ------------------------- Finished in 11.168364 seconds. 12 tests, 27 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 1.07 tests/s, 2.42 assertions/s Rubocop ------------------------- Running RuboCop... Inspecting 753 files 753 files inspected, no offenses detected
CER-296 This PR updates the installment data method to better handle when only certain fields are added. Remote Tests: 119 tests, 607 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.479% passed *3 failing tests also failing on master Unit Tests: 124 tests, 592 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local Tests: 5410 tests, 76913 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
DX-240 This adds a couple of Cabal 8 digit BIN ranges, and moves Cabal higher in the selection process since Discover has most of the BINs starting with 65 All local tests pass, did not run remote tests 5410 tests, 76915 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Summary: ------------------------------ In order to be able to store credentials, this commit adds add_stored_credentials method, and get_network_payment_reference to be used in network_transaction_id Remote Tests: ------------------------------ Finished in 36.906747 seconds. 16 tests, 42 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 2.793742 seconds. 16 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: ------------------------------ 753 files inspected, no offenses detected Co-authored-by: Gustavo Sanmartin <[email protected]>
Enables the `add_address` method to successfully find `email` whether it is nested at the top level of the `options` hash or within the `billing_address` object CER-330
This change aims to fix an bug related with the way to handle not supported card brands. Finished in 130.664153 seconds. 25 tests, 66 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Finished in 35.408869 seconds. 5415 tests, 76945 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 152.93 tests/s, 2173.04 assertions/s Inspecting 756 files 756 files inspected, no offenses detected
Summary:
------------------------------
In order to perform 'CIT-Setup-Unscheduled' this commit fix typo
from 'CIT-Setup-Unschedule' to 'CIT-Setup-Unscheduled'
Remote Tests:
------------------------------
Finished in 36.906747 seconds.
16 tests, 42 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit Tests:
------------------------------
Finished in 2.793742 seconds.
16 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Rubocop:
------------------------------
753 files inspected, no offenses detected
Summary: Add support to set service URL by setting the merchant country flag, with this capability openpay knows from which region is happening the transaction. Closes activemerchant#4637 Remote: 25 tests, 83 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96% passed Unit: 22 tests, 113 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop: 753 files inspected, no offenses detected
This change aims to prevent the extra call to get the access_token when the ecryption key expires also adds a change to properly filter out the access_token and encryption_key Closes activemerchant#4616 Remote Tests: Finished in 29.913157 seconds. 17 tests, 43 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: Finished in 64.281953 seconds. 5376 tests, 76737 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop 83.63 tests/s, 1193.76 assertions/s Running RuboCop... Inspecting 750 files
Summary: ------------------------------ Fixes a bug for Shift4 gateway to ensure that currency code is downcased. SER-811 Remote Test: ------------------------------ Finished in 34.37861 seconds. 34 tests, 121 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 47.584817 seconds. 5604 tests, 78022 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 766 files inspected, no offenses detected
Description ------------------------- Setup, scrub and purchase method to SumUp Gateway adapter with the basic information needed. This are the relevant links to review the initial implementation: [SumUp REST API](https://developer.sumup.com/docs/api/sum-up-rest-api/) [Make a payment with a card entered by a customer](https://developer.sumup.com/docs/online-payments/guides/single-payment/) [Checkouts](https://developer.sumup.com/docs/api/checkouts/) Tickets for Spreedly reference SER-764 SER-712 SER-711 Unit test ------------------------- Finished in 31.732818 seconds. 5611 tests, 78033 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Remote test ------------------------- 100% passed 176.82 tests/s, 2459.06 assertions/s Rubocop ------------------------- Inspecting 769 files 769 files inspected, no offenses detected Co-authored-by: Luis <[email protected]> Co-authored-by: Nick Ashton <[email protected]>
Description ------------------------- [SER-763](https://spreedly.atlassian.net/browse/SER-763) This commit add the initial setup for the new Xpay gateway Unit test ------------------------- Finished in 0.557754 seconds. 2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 3.59 tests/s, 7.17 assertions/s Remote test ------------------------- Finished in 0.557754 seconds. 2 tests, 4 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed 3.59 tests/s, 7.17 assertions/s Rubocop ------------------------- 769 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
…emerchant#4895) Description ------------------------- [SER-826](https://spreedly.atlassian.net/browse/SER-826) This commit add some validations to not send the cvv and network_reference_id on recurring transactions if it does not exist Unit test ------------------------- Finished in 0.132965 seconds. 34 tests, 163 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 79.856446 seconds. 40 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.5% passed Rubocop ------------------------- 766 files inspected, no offenses detected Co-authored-by: Javier Pedroza <[email protected]>
* Rapyd: Fix cvv validation Description ------------------------- This is a super small commit to update the validations to not send cvv value Unit test ------------------------- Finished in 0.132965 seconds. 34 tests, 163 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote test ------------------------- Finished in 79.856446 seconds. 40 tests, 115 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.5% passed Rubocop ------------------------- 766 files inspected, no offenses detected * Improve logic to check for valid ntid when deciding if we should send the * Use .blank? to check for cvv and validate presence of ntid before cvv check --------- Co-authored-by: Javier Pedroza <[email protected]> Co-authored-by: naashton <[email protected]>
This PR adds support for network tokens to the Decidir gateway.
CER-868 This field needs to be added to the transaction_hash method to be returned in the response. This also updates the Braintree gem, which was need to make these fields available Remote 107 tests, 212 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 31.7757% passed Unit 95 tests, 110 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 41.0526% passed Local 5599 tests, 77770 assertions, 0 failures, 56 errors, 0 pendings, 0 omissions, 0 notifications 98.9998% passed
Update bug that causes error is first_name and last_name are nil Remote: 31 tests, 86 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 27 tests, 136 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remote: 137 tests, 453 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.9708% passed Unit: 111 tests, 585 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
…bjects CER-757 These changes will enhance functionality for Credits/Payouts. The fields that are added with this logic are all opt-in, no existing logic has been changed. There are several fields that should be added conditionally, for this it would be best to reference the Checkout docs. Remote Tests: 96 tests, 231 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: 61 tests, 370 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local Tests: 5551 tests, 77653 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add new OAuth Response error handling to PayTrace, Quickbooks, Simetrik, Alelo, CheckoutV2 and Airwallex.
Only set merchant_initiated to false if initiator in stored_credential is cardholder. Unit 59 tests, 335 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote 93 tests, 227 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
This reverts commit 3931adf.
Co-authored-by: Gustavo Sanmartin <[email protected]>
Move add_shopper_data back to add_extra_data to ensure that shopperEmail is being sent in all transaction types. Unit: 112 tests, 589 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 137 tests, 455 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.9708% passed
Summary: ------------------------------ Fixes a bug for Kushki that fails transactions when 3DS info is passed for VISA Credit Cards. SER-830 Remote Test: ------------------------------ Finished in 87.534566 seconds. 24 tests, 71 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 37.30761 seconds. 5624 tests, 78070 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: ------------------------------ 772 files inspected, no offenses detected
CER-777 Adyen address fields are more European centric: `houseNumberOrName` and `street`. `address1` is currently mapped to `street` and `address2` is currently mapped to `houseNumberOrName` which causes AVS errors for users. This may be worth making a permanent change and removing the override in the future. Remote Tests: 138 tests, 457 assertions, 11 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 92.029% passed *11 failures are also failing on master Unit Tests: 113 tests, 595 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Local Tests: 5634 tests, 78165 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
ECS-3158 The existing logic for MIT flagging for any NT card (ApplePay, GooglePay, or NetworkToken) assume that they cannot be used with a `shopperInteraction` of `ContAuth`. This is not true as a merchant can perform MIT transactions with these payment methods if they skip adding MPI data. This commit updates the `shopper_interaction` logic so that NT payment methods on subsequent transactions will be flagged as `ContAuth` and skip adding MPI data for them. This commit also comments out Adyen's remote store tests as they are failing. A new ticket, ECS-3205, has been created to fix them. Remote Tests: 128 tests, 449 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add mpi fields to actions for cavv_purchase and cavv_preauth to make sure all external mpi data gets sent to Moneris. Unit 53 tests, 288 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote 52 tests, 248 assertions, 3 failures, 0 errors, 0 pendings, 1 omissions, 0 notifications 94.1176% passed
…ctivemerchant#4894) [SER-695](https://spreedly.atlassian.net/browse/SER-695) Unit tests ---------------- Finished in 0.129019 seconds. 49 tests, 207 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote tests ---------------- Finished in 288.734817 seconds 33 tests, 130 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 81.8182% passed
This reverts commit 2165af8.
Description ------------------------- Add Void and Refund calls to SumUp Gateway adapter with the basic information needed Add missing response statuses This are the relevant links to review the initial implementation: - [Deactivate a checkout](https://developer.sumup.com/docs/api/deactivate-a-checkout/) - [Make a refund](https://developer.sumup.com/docs/online-payments/guides/refund/) Tickets for Spreedly reference SER-713 Unit test ------------------------- Finished in 34.918843 seconds. 5614 tests, 78044 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications Remote test ------------------------- 100% passed 160.77 tests/s, 2235.01 assertions/s Rubocop ------------------------- Running RuboCop... Inspecting 769 files 769 files inspected, no offenses detected Co-authored-by: Luis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.