Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAI: creating mirror package #15105

Merged
merged 146 commits into from
Oct 27, 2022
Merged

LAI: creating mirror package #15105

merged 146 commits into from
Oct 27, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 12, 2022

What does this PR do?

repacing meta-package by mirror-package
interested in cross imports use copy source files
Requires (?) #15095
Closes #15122
Closes #15297

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @justusschock @awaelchli @rohitgr7 @tchaton @Borda

@Borda Borda added this to the v1.8 milestone Oct 12, 2022
@Borda Borda mentioned this pull request Oct 13, 2022
12 tasks
@Borda Borda marked this pull request as ready for review October 13, 2022 10:00
@Borda Borda requested a review from manskx as a code owner October 13, 2022 10:09
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 13, 2022
@Borda Borda added the priority: 1 Medium priority task label Oct 13, 2022
@Borda
Copy link
Member Author

Borda commented Oct 26, 2022

dropping building older CUDA images with olderPT version because of Apex, see: #15345

.github/checkgroup.yml Outdated Show resolved Hide resolved
.github/workflows/ci-lite-tests.yml Show resolved Hide resolved
.github/checkgroup.yml Outdated Show resolved Hide resolved
.github/checkgroup.yml Outdated Show resolved Hide resolved
@carmocca carmocca dismissed their stale review October 26, 2022 23:04

Will re-check when CI is green

@carmocca
Copy link
Contributor

The checkgroup.yml is broken after the master merge. Please be very careful with the update as errors there can block master. If you are unsure, let me make the updates.

@Borda
Copy link
Member Author

Borda commented Oct 27, 2022

Please be very careful with the update as errors there can block master. If you are unsure, let me make the updates.

sorry, and for sure will do :) from now on 🐰

@Borda
Copy link
Member Author

Borda commented Oct 27, 2022

as we are going to drop support for PT 19 in #15347 I am dropping testing for oldes and monolitic pkg

@Borda Borda requested a review from carmocca October 27, 2022 08:19
@carmocca
Copy link
Contributor

as we are going to drop support for PT 19 in #15347 I am dropping testing for oldes and monolitic pkg

I suggest we keep them in this PR in case this is merged and #15347 does not make it in time before the release (maybe because it gets blocked or PyTorch delays its release). So I would revert your latest commit

@lantiga lantiga disabled auto-merge October 27, 2022 10:24
@Borda
Copy link
Member Author

Borda commented Oct 27, 2022

I suggest we keep them in this PR in case this is merged and #15347 does not make it in time before the release

so how about keeping them but not setting them as required for now and @justusschock is checking them...

@carmocca
Copy link
Contributor

Okay. Fine with me

@lantiga lantiga merged commit 95ae393 into master Oct 27, 2022
@lantiga lantiga deleted the pkg/lai-source branch October 27, 2022 10:32
@Borda Borda mentioned this pull request Oct 27, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 1 Medium priority task ready PRs ready to be merged refactor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants