-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop PyTorch 1.9 support #15347
Drop PyTorch 1.9 support #15347
Conversation
PyTorch 1.13 is not yet out officially, so we shouldn't be dropping 1.9 yet |
I know. The release date is supposedly today |
Marking as ready to run tests. Still WIP |
This needs to be split into 2:
The latter is blocked by issues with IPUs and colossalai |
@carmocca For the latter, is the issue that these libraries don't provide a package with support for 1.13, or is it our implementation that needs updates? Since these are optional dependencies for Lightning, I don't think they should block us from providing support and testing of core for the latest pytorch version. |
I've removed all 1.13 related changes so that this can go before #15403. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the TPU docker removal
What does this PR do?
See title
Fixes #15346
Does your PR introduce any breaking changes? If yes, please list them.
Drops PyTorch 1.9 support, as expected by our support window
Before submitting
PR review
cc @carmocca @akihironitta @Borda @justusschock @awaelchli @rohitgr7