Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PyTorch 1.9 support #15347

Merged
merged 7 commits into from
Nov 10, 2022
Merged

Drop PyTorch 1.9 support #15347

merged 7 commits into from
Nov 10, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 26, 2022

What does this PR do?

See title

Fixes #15346

Does your PR introduce any breaking changes? If yes, please list them.

Drops PyTorch 1.9 support, as expected by our support window

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda @justusschock @awaelchli @rohitgr7

@carmocca carmocca added ci Continuous Integration refactor pl Generic label for PyTorch Lightning package labels Oct 26, 2022
@carmocca carmocca added this to the v1.8 milestone Oct 26, 2022
@carmocca carmocca self-assigned this Oct 26, 2022
@carmocca carmocca mentioned this pull request Oct 26, 2022
11 tasks
@Borda Borda mentioned this pull request Oct 27, 2022
12 tasks
@otaj
Copy link
Contributor

otaj commented Oct 27, 2022

PyTorch 1.13 is not yet out officially, so we shouldn't be dropping 1.9 yet

@carmocca
Copy link
Contributor Author

I know. The release date is supposedly today

@carmocca
Copy link
Contributor Author

Marking as ready to run tests. Still WIP

src/pytorch_lightning/CHANGELOG.md Outdated Show resolved Hide resolved
@Borda
Copy link
Member

Borda commented Oct 28, 2022

@carmocca, how much is missing here?
UPDATE: with #15403 are free to drop support of 1.9 🦦

@mergify mergify bot removed the has conflicts label Oct 31, 2022
@Borda Borda removed this from the v1.8 milestone Oct 31, 2022
@Borda Borda added this to the v1.8.x milestone Oct 31, 2022
@carmocca
Copy link
Contributor Author

This needs to be split into 2:

  • Drop 1.9 support
  • Add 1.13 testing

The latter is blocked by issues with IPUs and colossalai

@awaelchli
Copy link
Contributor

@carmocca For the latter, is the issue that these libraries don't provide a package with support for 1.13, or is it our implementation that needs updates?
How about we keep the IPU job running on 1.12? And run colossalai tests only on <= 1.12? If Graphcore and Colossal don't release new packages before our next release, we can implement checks that inform the user that these strategies are not yet supported on pytorch >= 1.13.

Since these are optional dependencies for Lightning, I don't think they should block us from providing support and testing of core for the latest pytorch version.

@carmocca
Copy link
Contributor Author

carmocca commented Nov 9, 2022

I've removed all 1.13 related changes so that this can go before #15403.
Note that we need to update IPUs because they use 1.9

@carmocca carmocca changed the title [WIP] Drop PyTorch 1.9 support Drop PyTorch 1.9 support Nov 9, 2022
dockers/tpu-tests/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the TPU docker removal

@carmocca carmocca enabled auto-merge (squash) November 10, 2022 00:35
@mergify mergify bot added the ready PRs ready to be merged label Nov 10, 2022
@carmocca carmocca added the admin Requires admin privileges to merge label Nov 10, 2022
@lexierule lexierule merged commit 6ba00af into master Nov 10, 2022
@lexierule lexierule deleted the ci/drop-1.9 branch November 10, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Requires admin privileges to merge ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged refactor
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Drop PyTorch 1.9 support
6 participants