Handle unknown background formats gracefully #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dimensions of the background image are used as a default window size if the specification does not contain a `window.size` object. Skipping this is useful because reading the background image's dimensions won't work if it's in a format that `image-size` doesn't understand, particularly PDF.
When reading the background image's dimensions fails, appdmg now tells the user that the error can be avoided by giving `window.size` in the JSON specification.
|
It would also be useful to update the readme to mention that PDF is supported as background. Here:
And here: https://github.com/LinusU/node-appdmg#retina-background |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the image formats supported by Finder for the background image is, somewhat surprisingly, PDF. That's a vector graphics format, so this could be used to make a single background image that scales cleanly to any screen resolution, without having to make a separate
@2xversion of the image.Problem: appdmg chokes when trying to use a PDF as the background image, because
image-sizedoesn't understand that format (and PDF doesn't have a pixel size anyway).This PR does two things to help with that problem:
image-sizeif awindow.sizeis given in the JSON specification file.image-sizefails, give a helpful error message that explains what actually happened (couldn't read the image size) and how to avoid it (by giving awindow.size).