Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknown background formats gracefully #174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle unknown background formats gracefully #174

wants to merge 2 commits into from

Commits on May 1, 2019

  1. Skip reading background dimensions if they aren't needed. 

    The dimensions of the background image are used as a default window size if the specification does not contain a `window.size` object.

Skipping this is useful because reading the background image's dimensions won't work if it's in a format that `image-size` doesn't understand, particularly PDF.
    @argv-minus-one
    argv-minus-one committed May 1, 2019
    Configuration menu
    Copy the full SHA
    34a40e1 View commit details
    Browse the repository at this point in the history

  2. Better error message for “reading background dimensions” step. 

    When reading the background image's dimensions fails, appdmg now tells the user that the error can be avoided by giving `window.size` in the JSON specification.
    @argv-minus-one
    argv-minus-one committed May 1, 2019
    Configuration menu
    Copy the full SHA
    1f501a1 View commit details
    Browse the repository at this point in the history