Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Introduce interoperability_getMainchainID endpoint #8758

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

sitetester
Copy link
Contributor

What was the problem?

This PR resolves #8309

How was it solved?

Endpoint introduced

How was it tested?

Test cases added

@sitetester sitetester self-assigned this Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #8758 (9fe727c) into release/6.0.0 (970b641) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9fe727c differs from pull request most recent head c2160c6. Consider uploading reports for the commit c2160c6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/6.0.0    #8758   +/-   ##
==============================================
  Coverage          83.31%   83.32%           
==============================================
  Files                594      594           
  Lines              22312    22315    +3     
  Branches            3291     3289    -2     
==============================================
+ Hits               18589    18593    +4     
+ Misses              3723     3722    -1     
Files Changed Coverage Δ
...k/src/modules/interoperability/sidechain/module.ts 95.83% <ø> (ø)
framework/src/modules/interoperability/schemas.ts 100.00% <100.00%> (ø)
...src/modules/interoperability/sidechain/endpoint.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@shuse2 shuse2 removed the request for review from ishantiw July 27, 2023 09:24
Copy link
Contributor

@mitsuaki-u mitsuaki-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @shuse2 commented logic should be in sidechain endpoint and additionally update module.ts -> metadata -> endpoints with any required schemas

@sitetester sitetester force-pushed the 8309-add-getMainchainID-endpoint branch from f6e28f6 to 9fe727c Compare July 27, 2023 15:35
@shuse2 shuse2 requested a review from mitsuaki-u July 28, 2023 09:20
@shuse2 shuse2 enabled auto-merge (squash) July 31, 2023 13:43
@shuse2 shuse2 merged commit b258bc2 into release/6.0.0 Jul 31, 2023
8 checks passed
@shuse2 shuse2 deleted the 8309-add-getMainchainID-endpoint branch July 31, 2023 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants