Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect CompletionItemKind for postfix snippets #2773

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

tmillr
Copy link
Contributor

@tmillr tmillr commented Jul 29, 2024

No description provided.

@sumneko
Copy link
Collaborator

sumneko commented Jul 29, 2024

I just like the icon of Event

image

@max397574
Copy link
Contributor

Well for many clients apart from vscode users configure these icons themselves and imo this is just wrong. E.g. if someone would want to implement a filter function for kinds this would be really confusing.

@tmillr
Copy link
Contributor Author

tmillr commented Jul 29, 2024

I just like the icon of Event

image

Is there any way to configure or customize that locally in your editor?

It'd be much better for this to be semantically correct, but it's your call at the end of the day.

For example, with the way it is now:

  • Code or plugins using an LSP client cannot rely on CompletionItemKind, because this server gives the wrong value.
  • Color-schemes have to account for and depend on this bug in order to display themselves correctly.

@tomlau10
Copy link
Contributor

Seems customizing intellisense icons has long been proposed in vscode, but the issue got closed and not implemented in the end ☹️ microsoft/vscode#27764

@tomlau10
Copy link
Contributor

Oh I just found that there are product icon themes extensions that modify product icons including these suggestion icons,
as opposed to file icon themes which just modify file icons in tree view.
https://www.youtube.com/watch?v=aLCzInfPqo8

I followed the video above and installed a Material Product Icons extension, and the suggestion icons just feel much better 😂 . Especially the snippet icon, which in the default theme it looks like a strange empty square 🙄.

Below shows the before after differences:
image

Is there any way to configure or customize that locally in your editor?

I suggest @sumneko can test it out, and I vote for "It'd be much better for this to be semantically correct" 👍

@sumneko
Copy link
Collaborator

sumneko commented Jul 31, 2024

Please also fix the tests

@tmillr tmillr force-pushed the patch-1 branch 3 times, most recently from 01827b4 to 30fef47 Compare August 1, 2024 00:05
@sumneko sumneko merged commit ed8559e into LuaLS:master Aug 1, 2024
11 checks passed
@tmillr
Copy link
Contributor Author

tmillr commented Aug 2, 2024

Awesome, thanks for fixing this!

@tmillr tmillr deleted the patch-1 branch August 2, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants