Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Improve Auto Detect slumber.yaml #194

Closed
kristopherbullinger opened this issue May 1, 2024 · 1 comment · Fixed by #195
Closed

feature request: Improve Auto Detect slumber.yaml #194

kristopherbullinger opened this issue May 1, 2024 · 1 comment · Fixed by #195
Labels
qol Improvements that make usage smoother, without introducing new functionality

Comments

@kristopherbullinger
Copy link

Motivation

If the user wishes to use slumber in a directory where a slumber.yaml file is not present, slumber will fail to start with an error unless the user specifies the location manually. This is inconvenient unless the user happens to be working in the same directory that their slumber.yaml is defined.

Feature Description

Allow slumber to check the current directory as it currently does, but instead of terminating on failing to find the config file in the current directory, check the parent directories in order until the root is reached (upon which slumber terminates) or a slumber.yaml is found.

Prior Art

dotenvy

Note

As the location of the detected config file may be less apparent to the user, I suggest adding a diagnostic message at the bottom of the TUI declaring the location of the slumber.yaml file which was detected, similar to when slumber reloads upon detecting a change to the config file.

[13:33:11] Loaded collection from /user/abcdefghi/slumber.yaml
@LucasPickering LucasPickering added the qol Improvements that make usage smoother, without introducing new functionality label May 1, 2024
LucasPickering added a commit that referenced this issue May 1, 2024
- If a collection file isn't found in the current directory, recursively search our parents (up to the fs root) to find it.
- Print a notification on startup to show the loaded collection file (similar to what shows after a reload)

Closes #194
LucasPickering added a commit that referenced this issue May 1, 2024
- If a collection file isn't found in the current directory, recursively search our parents (up to the fs root) to find it.
- Print a notification on startup to show the loaded collection file (similar to what shows after a reload)

Closes #194
@LucasPickering
Copy link
Owner

LucasPickering commented May 1, 2024

Thanks for the suggestion, just put up a PR. Also FWIW you can check the collection file path any time in the help menu (?) in the TUI:

image

LucasPickering added a commit that referenced this issue May 1, 2024
- If a collection file isn't found in the current directory, recursively search our parents (up to the fs root) to find it.
- Print a notification on startup to show the loaded collection file (similar to what shows after a reload)

Closes #194
LucasPickering added a commit that referenced this issue May 1, 2024
- If a collection file isn't found in the current directory, recursively search our parents (up to the fs root) to find it.
- Print a notification on startup to show the loaded collection file (similar to what shows after a reload)

Closes #194
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 6, 2024
[1.1.0] - 2024-05-05

Added
- Add `section` field to `!request` chain values, to allow chaining response headers rather than body ([#184](LucasPickering/slumber#184))
- Add action to save response body to file ([#183](LucasPickering/slumber#183))
- Add `theme` field to the config, to configure colors ([#193](LucasPickering/slumber#193))
  - [See docs](https://slumber.lucaspickering.me/book/api/configuration/theme.html) for more info
- Add `stdin` option to command chains ([#190](LucasPickering/slumber#190))

Changed
- Reduce UI latency under certain scenarios
  - Previously some actions would feel laggy because of an inherent 250ms delay in processing some events
- Search parent directories for collection file ([#194](LucasPickering/slumber#194))
- Use thicker borders for selected pane and modals
- Change default TUI colors to blue and yellow

Fixed
- Fix Slumber going into zombie mode and CPU spiking to 100% under certain closure scenarios ([#136](LucasPickering/slumber#136))
- Fix historical request/response no loading on first render ([#199](LucasPickering/slumber#199))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qol Improvements that make usage smoother, without introducing new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants