Luka jcb add monoidal to monoid #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sbt-coursier 1.0.0 * sbt-coursier 1.0.0
* Add comparison method in Order companion object The main goal of this PR was to add syntax for the `Order` and `PartialOrder` syntax (provided via machinist ops) to address [this comment](typelevel#1867 (comment)). In the process I noticed that the Order companion object didn't have a `comparison` function to forward through to the type class instance like it did for other methods, so I added that. I did notice that the `Order`/`PartialOrder` syntax does work whether or not you take the `Order`/`PartialOrder` instances as implicit parameters to the ops classes. I think that only @non understands quite what's going on with the machinist syntax macros, so I didn't make the changes to take away those implicit parameters without knowing the implications. The tests pass either way, so I think that end-code should work for users either way. * Change PartialOrder syntax tests to handle NaN
kailuowang
commented
Dec 18, 2017
| @@ -135,16 +135,6 @@ private[data] sealed abstract class ConstInstances0 extends ConstInstances1 { | |||
| } | |||
|
|
|||
| private[data] sealed abstract class ConstInstances1 { | |||
| implicit def catsConstInvariantMonoidal[C: Monoid]: InvariantMonoidal[Const[C, ?]] = new InvariantMonoidal[Const[C, ?]] { | |||
There was a problem hiding this comment.
already provided by Applicative
LukaJCB
approved these changes
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I also included master commits. The last two commits are new