Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luka jcb add monoidal to monoid #3

Commits on Dec 17, 2017

  1. sbt-coursier 1.0.0 (typelevel#2114)

    * sbt-coursier 1.0.0
    
    * sbt-coursier 1.0.0
    sullis authored and kailuowang committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    9bdc67b View commit details
    Browse the repository at this point in the history
  2. Add comparison method in Order companion object (typelevel#2100)

    * Add comparison method in Order companion object
    
    The main goal of this PR was to add syntax for the `Order` and
    `PartialOrder` syntax (provided via machinist ops) to address [this comment](typelevel#1867 (comment)).
    
    In the process I noticed that the Order companion object didn't have a
    `comparison` function to forward through to the type class instance like
    it did for other methods, so I added that.
    
    I did notice that the `Order`/`PartialOrder` syntax does work whether or
    not you take the `Order`/`PartialOrder` instances as implicit parameters
    to the ops classes. I think that only @non understands quite what's
    going on with the machinist syntax macros, so I didn't make the changes
    to take away those implicit parameters without knowing the implications.
    The tests pass either way, so I think that end-code should work for
    users either way.
    
    * Change PartialOrder syntax tests to handle NaN
    ceedubs authored and LukaJCB committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    dda5df3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2017

  1. Configuration menu
    Copy the full SHA
    4d92b99 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'add-monoidal-to-monoid' of https://github.com/LukaJCB/cats

     into LukaJCB-add-monoidal-to-monoid
    kailuowang committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    3e3982f View commit details
    Browse the repository at this point in the history
  3. use uinit for laws

    kailuowang committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    95f58ff View commit details
    Browse the repository at this point in the history
  4. improve test coverage

    kailuowang committed Dec 18, 2017
    Configuration menu
    Copy the full SHA
    4b73af8 View commit details
    Browse the repository at this point in the history