Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml, activate towncrier, update release workflow #211

Merged
merged 8 commits into from
May 6, 2024

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented May 3, 2024

Description of the change

Progress of the PR

  • Change implemented (can be split into several points),
  • docstring updated (if appropriate),
  • update user guide (if appropriate),
  • [n/a] added tests,
  • added changelog entries to upcoming_changes,
  • test formatting of changelog,
  • ready for review.

@jlaehne jlaehne added this to the v0.3 milestone May 3, 2024
@jlaehne jlaehne mentioned this pull request May 3, 2024
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (681442a) to head (dc82df1).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #211   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        12    -1     
  Lines          565       552   -13     
=========================================
- Hits           565       552   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lumispy/__init__.py Fixed Show fixed Hide fixed
lumispy/__init__.py Fixed Show fixed Hide fixed
doc/conf.py Fixed Show fixed Hide fixed
doc/conf.py Fixed Show fixed Hide fixed
@jlaehne jlaehne force-pushed the pyproject branch 2 times, most recently from 0a6a88d to fc4695e Compare May 3, 2024 13:26
@jlaehne jlaehne force-pushed the pyproject branch 3 times, most recently from 1be48fa to e174403 Compare May 3, 2024 17:20
@jlaehne jlaehne force-pushed the pyproject branch 2 times, most recently from 58c923d to 9bf3828 Compare May 3, 2024 18:16
@jlaehne
Copy link
Contributor Author

jlaehne commented May 3, 2024

@ericpre is there a way to make the hyperspy package_and_test workflow available for lumispy or should I work on simplifying the copy made here instead? As far as I can see, in particular `l65 is incompatible with being called from outside the hyperspy organization.

@ericpre
Copy link
Contributor

ericpre commented May 3, 2024

Can you try now after hyperspy/.github@c5376fc?

@jlaehne
Copy link
Contributor Author

jlaehne commented May 3, 2024

Can you try now after hyperspy/.github@c5376fc?

Still trying to run git remote add upstream https://github.com/hyperspy/lumispy.git:
https://github.com/LumiSpy/lumispy/actions/runs/8944482220/job/24571487005?pr=211

@jlaehne
Copy link
Contributor Author

jlaehne commented May 3, 2024

Can you try now after hyperspy/.github@c5376fc?

Still trying to run git remote add upstream https://github.com/hyperspy/lumispy.git: https://github.com/LumiSpy/lumispy/actions/runs/8944482220/job/24571487005?pr=211

OK, now I figured that I have to pass the ORGANISATION and it is running through :-)

Copy link
Contributor

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks all good and working as expected.

I think that it should be possible to remove the MANIFEST.in file.

  • Do we need to change anything on the zenodo setup?

Not that I am aware of!

Is it worth updating the doc workflow? For example:

https://github.com/hyperspy/rosettasciio/blob/fa68311843db1e10d070d23c6691289c3b93ba32/.github/workflows/docs.yml#L1-L12

@jlaehne
Copy link
Contributor Author

jlaehne commented May 5, 2024

Is it worth updating the doc workflow? For example:

I see that the [push_doc.yml](https://github.com/hyperspy/.github/blob/main/.github/workflows/push_doc.yml) workflow relies on tokens that can probably not be shared across organisations?

@ericpre
Copy link
Contributor

ericpre commented May 6, 2024

Which tokens?

This is the workflow:
https://github.com/hyperspy/.github/blob/main/.github/workflows/doc.yml

@jlaehne
Copy link
Contributor Author

jlaehne commented May 6, 2024

doc.yml uses push_doc.yml, which uses access tokens: https://github.com/hyperspy/.github/blob/c5376fc1205d57561ac5e15620df4e5799465a5c/.github/workflows/push_doc.yml#L83

I'll merge this PR and the doc workflow could become a new one.

@jlaehne jlaehne merged commit e826dbf into LumiSpy:main May 6, 2024
20 checks passed
@jlaehne jlaehne deleted the pyproject branch September 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants