Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate package metadata in pyproject.toml, use setuptools_scm and add python 3.12 #14

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Nov 11, 2023

Progress of the PR

  • Consolidate package metadata in pyproject.toml,
  • Use setuptools_scm to set version in package at build time,
  • Add python 3.12,
  • [n/a] docstring updated (if appropriate),
  • update user guide (releasing_guide.md),
  • added tests (package and test workflow),
  • added line to CHANGES.rst,
  • ready for review.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9eceecf) 94.41% compared to head (50c8302) 87.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   94.41%   87.38%   -7.04%     
==========================================
  Files          12        7       -5     
  Lines         591      325     -266     
  Branches        0       72      +72     
==========================================
- Hits          558      284     -274     
+ Misses         33       25       -8     
- Partials        0       16      +16     
Files Coverage Δ
holospy/__init__.py 85.71% <100.00%> (-3.18%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre force-pushed the use_pyproject.toml branch 2 times, most recently from 224219c to 5b4bbda Compare November 11, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant