Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ko translations #600

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Update ko translations #600

merged 1 commit into from
Aug 15, 2024

Conversation

derornos
Copy link
Contributor

Description

Update ko translations

  • src/assets/locales/ko.json, ...

Checklist:

  • [ o ] I have performed a self-review of my code
  • [ o ] I tried to follow the KISS principle

@Lurkars
Copy link
Owner

Lurkars commented Jul 16, 2024

I know it's easier to translate, if you have the English texts there to know what's missing. The issue is, that English is always fallback for missing label. If I now fix typos in English translations. The texts in KO will be wrong in first place and if you took this file to translate, you may also translate outdated/wrong labels. So I would suggest to remove all non-translated texts and try to work with an useful DIFF tool to see what's missing. (I may just implement a tool to show missing label?)

Copy link
Owner

@Lurkars Lurkars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, remove all English label from file.

@derornos
Copy link
Contributor Author

Thank you for your comments.

I'm adding English labels for the following reasons

  1. history management
    If some label updates are added and a long time passes, I may not notice and miss some of them. Often, when I compare the ko.json file with the en.json or de.json file after completing the translation, I find that the total number of lines is different because of the missing labels. As a result, I spend a lot of time trying to find the missing labels.
  2. Apply a quick update
    Often, updates to labels occur simultaneously across all json files under a locale. If that label doesn't exist in the ko.json file at that time, I can't figure out if the update has occurred or not.

Incidentally, the reason I don't use DIFF is that some ko.json files use labels that don't exist in the en.json file, but I'm constantly doing basic comparisons with the DIFF tool via VSCode to gain insights.

If you support scripts that can do the same thing, such as the file you can find in the link below, I might not mind the issues mentioned above.
ex. update_locales

@Lurkars Lurkars merged commit 74c2667 into Lurkars:main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants