Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to gromacs manual for xtc #387

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Add reference to gromacs manual for xtc #387

merged 3 commits into from
Oct 15, 2024

Conversation

RubenChM
Copy link
Contributor

@RubenChM RubenChM commented Oct 11, 2024 •
edited by github-actions bot
Loading

@RMeli RMeli mentioned this pull request Oct 11, 2024
Merged
@RMeli
Copy link
Member

RMeli commented Oct 11, 2024

Thanks @RubenChM! CI is failing for issues, un-related to this PR. It should be fixed in #388.

@RMeli
Copy link
Member

RMeli commented Oct 11, 2024

While we wait for #388, would you mind adding yourself to the AUTHORS file, if you aren't there already?

@tylerjereddy tylerjereddy changed the title Add reference to gromax manual for xtc Add reference to gromacs manual for xtc Oct 11, 2024
@RMeli
Copy link
Member

RMeli commented Oct 14, 2024

@RubenChM can you please merge develop into this branch? It should fix the CI issue. Thank you.

RMeli
RMeli approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @RubenChM!

@RMeli RMeli merged commit 2a36ebd into MDAnalysis:develop Oct 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubenChM @RMeli