-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setup-python instead of setup-micromamba for pre-commit CI #388
Conversation
We had a failure in #387. Trying to see if using Others encountered the same issue pre-commit/action#214, pre-commit/action#213, pre-commit/action#210. Honestly, the replies from the maintainer on these issues makes me want to steer clear of the Additionally:
Maybe we should consider moving to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know very little about the background here. I am providing a "LGTM" because it looks sensible to use a simple python setup to run pre-commit and because you are of the opinion that it will improve the CI and because it didn't visibly break anything.
If someone with more experience could have a look then that would be good, of course, but I ultimately trust that you know what you're doing.
I could not find much information on why this is happening now. But it seems that the action is only in maintenance mode, and the maintainer is very quick at closing issues. In the ones outlining this problem (linked above, links were wrong and I just updated them), replies are of the sort
or
So not much information there. The README uses the |
The maintainer comments on the pre-commit issues are not particularly welcoming. I don't quite know what would be better for a "maintenance-only" project: no response at all or harsh responses + shutting down issues. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like the precomit action is doing something reasonably nefarious.. I do agree that moving away from it would be good.
📚 Documentation preview 📚: https://mdanalysisuserguide--388.org.readthedocs.build/en/388/