Reduce docker image size #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2021 00:47
…lation and by removing apt cache
|
Well I have just tried it, the I just had a problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the continuation of #148 .
It did not had time to test this
Dockerfileyet (the first build took so much time).I will confirm these changes when I have time to build the new image.
I have only tested by removing Euroc zip file, local binaries and apt cache from container, exporting new image and importing it back (7.14 GB vs 17.9GB).
Moreover, I am not a Docker expert, but according to this #minimize-the-number-of-layers each RUN/ADD/COPY creates a new layer and this #use-multi-stage-builds could be a solution.
However, the way you did this is very clear and easy to understand ! 👍