Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DISMF dataset name in global ocean forward runs #789

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 12, 2024

This got missed in the pull request (#778) that switched to Paolo et al. (2023) melt rates.

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

This got missed in the pull request that switched to Paolo et al.
(2023) melt rates.
@xylar xylar self-assigned this Mar 12, 2024
@xylar xylar requested a review from cbegeman March 12, 2024 12:37
@xylar xylar added bug Something isn't working ocean labels Mar 12, 2024
@xylar
Copy link
Collaborator Author

xylar commented Mar 12, 2024

Testing

I was able to run the QUwISC240 mesh, init and performance_test test cases with this branch on Chrysalis, whereas the data_ice_shelf_melt step failed without this fix.

@xylar
Copy link
Collaborator Author

xylar commented Mar 12, 2024

I am not currently able to run the pr suite because of missing cache files, an issue I will fix in a separate PR.

@xylar
Copy link
Collaborator Author

xylar commented Mar 12, 2024

@cbegeman. this one just needs a very quick review by inspection, as I think it's an obvious fix.

@xylar xylar merged commit e54c198 into MPAS-Dev:main Mar 12, 2024
4 checks passed
@xylar
Copy link
Collaborator Author

xylar commented Mar 12, 2024

Shoot, I merged this by mistake as part of #791

@xylar xylar deleted the fix-global-ocean-forward-with-dismf branch March 12, 2024 21:00
@xylar xylar removed the request for review from cbegeman March 12, 2024 21:00
@cbegeman
Copy link
Collaborator

@xylar That's ok. It's an obvious change. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants