-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch DISMF to Paolo et al. (2023) dataset #778
Conversation
TestingI ran
This corresponds to a total flux of 948 Gt/yr, which is pretty close to the total of 961 Gt/yr that I calculated based on the bottom row of Table 3 of the Paolo et al. (2023) paper. I copied the resulting file to:
|
@darincomeau and @cbegeman, this is a follow-up on #777 |
@xylar Any testing you'd like me to do? |
558e381
to
42e3b24
Compare
With the latest changes, when I test
|
42e3b24
to
31b1a24
Compare
I ran this for the newest SORRM and RRS meshes, with similar results. SORRM:
RRS:
|
I have placed new DISMF files at:
|
latent_heat_of_fusion = constants['SHR_CONST_LATICE'] | ||
ds['x'] = x | ||
ds['y'] = y | ||
area_ratio = planar_area / sphere_area |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar Great!
@cbegeman and @darincomeau, Could you review this and #777 based on my testing and this analysis output? Feel free to suggest (or do) any further testing that you think is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the testing done so far, the fact that this dataset is more accurate than its predecessor, and the fact that the total ice shelf freshwater flux from the ocean analysis member is consistent with the source dataset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on existing testing. Thanks @xylar !
Since the original mass is on the plane, fluxes must be scaled by the ratio of the area on the plan to the area on the sphere to ensure that the remapped flux has the expected sum. For good measure, this merge also rescales the flux after remapping using the area on the sphere over MPAS's `areaCell` (which are very close).
784b7ba
to
5da9d95
Compare
Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
in this PR) any testing that was used to verify the changes