Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch DISMF to Paolo et al. (2023) dataset #778

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Feb 20, 2024

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added enhancement New feature or request ocean labels Feb 20, 2024
@xylar xylar self-assigned this Feb 20, 2024
@xylar
Copy link
Collaborator Author

xylar commented Feb 20, 2024

Testing

I ran files_for_e3sm/remap_ice_shelf_melt step on the IcoswISC30E3r5 mesh and saw:

Rerouting fluxes from 1054 cells
Captured flux (kg/s):         18653044.8
Rerouted flux (kg/s):         11399309.2
Total flux (kg/s):            30052354.0
Total after rerouting (kg/s): 30052354.0

This corresponds to a total flux of 948 Gt/yr, which is pretty close to the total of 961 Gt/yr that I calculated based on the bottom row of Table 3 of the Paolo et al. (2023) paper.

I copied the resulting file to:

/lcrc/group/e3sm/public_html/inputdata/ocn/mpas-o/IcoswISC30E3r5/prescribed_ismf_paolo2023.IcoswISC30E3r5.20240220.nc

@xylar
Copy link
Collaborator Author

xylar commented Feb 20, 2024

@darincomeau and @cbegeman, this is a follow-up on #777

@cbegeman
Copy link
Collaborator

I support switching to this dataset. Based on this figure from Paolo et al. (2023), the Paolo dataset is more accurate than the Adusumilli dataset (panel d shows better agreement with flux gate method vs. panel c).
image

Figure 8Comparison of estimates from this study with previous work. Comparison of (a, c) Adusumilli et al. (2020) and (b, d) this study's ice shelf basal melt estimates against a control-volume calculation of ice shelf mass change (line). The control volume is based on the input and output fluxes across the grounding line and ice front, mass gained or lost due to surface mass balance (a, b), and ice loss due to anomalies in basal melt (c, d). For this comparison, we only considered grid cells that are at least 90 % hydrostatically compensated (near fully floating).

@cbegeman
Copy link
Collaborator

@xylar Any testing you'd like me to do?

@xylar
Copy link
Collaborator Author

xylar commented Feb 21, 2024

With the latest changes, when I test remap_ice_shelf_melt on the IcoswISC30E3r5 mesh, I'm seeing:

min projected area ratio: 0.9547266742733075
max projected area ratio: 1.1524603930432318

Area of a cell (m^2):            3686400.0
Total flux on plane (kg/s):      30023072.2
Total flux on sphere (kg/s):     30023072.2

min MPAS area ratio: 0.9999999298969185
max MPAS area ratio: 1.0000000668051465

Total flux w/ MPAS area (kg/s):  30023072.2
Total flux w/ sphere area(kg/s): 30023072.2
Rerouting fluxes from 1054 cells
Captured flux (kg/s):            18636267.0
Rerouted flux (kg/s):            11386805.2
Total flux (kg/s):               30023072.2
Total after rerouting (kg/s):    30023072.2

@xylar
Copy link
Collaborator Author

xylar commented Feb 21, 2024

I ran this for the newest SORRM and RRS meshes, with similar results.

SORRM:

Total flux w/ MPAS area (kg/s):   30023072.2
Total flux w/ sphere area (kg/s): 30023072.2
Rerouting fluxes from 2756 cells
Captured flux (kg/s):             24748633.5
Rerouted flux (kg/s):              5274438.8
Total flux (kg/s):                30023072.2
Total after rerouting (kg/s):     30023072.2

RRS:

Total flux w/ MPAS area (kg/s):   30023072.2
Total flux w/ sphere area (kg/s): 30023072.2
Rerouting fluxes from 5564 cells
Captured flux (kg/s):             27235388.8
Rerouted flux (kg/s):              2787683.5
Total flux (kg/s):                30023072.2
Total after rerouting (kg/s):     30023072.2

@xylar
Copy link
Collaborator Author

xylar commented Feb 21, 2024

I have placed new DISMF files at:

/lcrc/group/e3sm/public_html/inputdata/ocn/mpas-o/IcoswISC30E3r5/prescribed_ismf_paolo2023.IcoswISC30E3r5.20240221.nc
/lcrc/group/e3sm/data/inputdata/ocn/mpas-o/SOwISC12to30E3r2/prescribed_ismf_paolo2023.SOwISC12to30E3r2.20240221.nc
/lcrc/group/e3sm/data/inputdata/ocn/mpas-o/RRSwISC6to18E3r4/prescribed_ismf_paolo2023.RRSwISC6to18E3r4.20240221.nc

latent_heat_of_fusion = constants['SHR_CONST_LATICE']
ds['x'] = x
ds['y'] = y
area_ratio = planar_area / sphere_area
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Great!

@xylar
Copy link
Collaborator Author

xylar commented Feb 23, 2024

@cbegeman and @darincomeau,

Could you review this and #777 based on my testing and this analysis output?
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis/20240223.v3.LR.CRYO1850-DISMF.paolo.chrysalis/

Feel free to suggest (or do) any further testing that you think is needed.

@xylar xylar marked this pull request as ready for review February 23, 2024 10:11
Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the testing done so far, the fact that this dataset is more accurate than its predecessor, and the fact that the total ice shelf freshwater flux from the ocean analysis member is consistent with the source dataset.

Copy link
Collaborator

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on existing testing. Thanks @xylar !

Since the original mass is on the plane, fluxes must be scaled
by the ratio of the area on the plan to the area on the sphere
to ensure that the remapped flux has the expected sum.

For good measure, this merge also rescales the flux after remapping
using the area on the sphere over MPAS's `areaCell` (which are
very close).
@xylar xylar merged commit 588e1cc into MPAS-Dev:main Feb 25, 2024
4 checks passed
@xylar xylar deleted the use-paolo-for-dismf branch February 25, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants