Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrregister: fix lmax check for nonlinear multi contrast registration #2300

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

maxpietsch
Copy link
Member

Fixes the error reported in the community. Also added more verbose error messages to population_template

jdtournier
jdtournier previously approved these changes Mar 30, 2021
@maxpietsch
Copy link
Member Author

maxpietsch commented Mar 30, 2021

Pylint seems to be broken for python2:

logging to "pylint.log"
Using pylint for python2 (from PYTHON environment variable)
/usr/bin/python2: No module named pylint
testing "build"... ERROR

Also on repeated CI run. I think CI uses pylint 2.4.4-2 but >2.0 allegedly is not supported for python 2.7.

@maxpietsch maxpietsch force-pushed the registration_mc_lmaxcheck_fix branch 2 times, most recently from dc04111 to d4e1616 Compare March 30, 2021 16:00
@maxpietsch
Copy link
Member Author

Couldn't get pylint to work for python2 so removed it from the checks assuming we're going to drop python2 support anyway (#2047).

@maxpietsch maxpietsch added this to the 3.0.3 hotfix milestone Apr 6, 2021
Copy link
Member

@jdtournier jdtournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not having pylint for Python2 is not a big deal, and certainly not worth holding this up for, as we're phasing out Python2 support anyway... 👍

@jdtournier jdtournier merged commit 722d158 into master Apr 6, 2021
@jdtournier jdtournier deleted the registration_mc_lmaxcheck_fix branch April 6, 2021 11:18
@Lestropie Lestropie mentioned this pull request Apr 13, 2021
@Lestropie Lestropie modified the milestones: 3.0.4 hotfix, 3.0.3 hotfix May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants