Ensure Pylint<2.0.0 on Python 2.x #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
=========================================
+ Coverage 79.85% 80% +0.14%
=========================================
Files 308 308
Lines 14167 14180 +13
Branches 2519 2520 +1
=========================================
+ Hits 11313 11344 +31
+ Misses 2842 2824 -18
Partials 12 12
Continue to review full report at Codecov.
|
brettcannon
suggested changes
Jul 17, 2018
| if (currentInterpreter && currentInterpreter.version_info && currentInterpreter.version_info[0] === 2) { | ||
| const newArgs = [...args]; | ||
| // This command could be sent to the terminal, hence '<' needs to be escaped for Mac. | ||
| newArgs[indexOfPylint] = '"pylint<=2.0.0"'; |
brettcannon
approved these changes
Jul 17, 2018
|
@DonJayamanne to get CI to complete faster I have gone ahead and edited your code to pass |
brettcannon
changed the title
…honVSCode into issue2163Pylint * 'issue2163Pylint' of https://github.com/DonJayamanne/pythonVSCode: Python 2.7 requires older than 2.0.0
DonJayamanne
changed the title
bschley
pushed a commit
to bschley/vscode-python
that referenced
this pull request
Aug 2, 2018
* Ensure Pylint<=2.0.0 on Python 2.x * Python 2.7 requires older than 2.0.0 * tests * Add Tests * Fix broken tests * Redue nesting of suites
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2057
"1.2.3", not"^1.2.3")package-lock.jsonhas been regenerated if dependencies have changed