Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular merge of master hotfixes to dev #2673

Merged
merged 28 commits into from
Jul 6, 2023
Merged

Regular merge of master hotfixes to dev #2673

merged 28 commits into from
Jul 6, 2023

Conversation

Lestropie
Copy link
Member

Triggered in particular to grab file .git-blame-ignore-revs added in #2592 to be used in #2652.

Some minor conflicts arising from:

jdtournier and others added 28 commits January 19, 2023 15:07
mrview: change option name -orientationlabel to avoid conflict with -orientation
…nlabel_option

Revert "mrview: change option name -orientationlabel to avoid conflict with -orientation"
The plan is to make use of GitHub's new merge queue feature, to reduce
the faff when trying to merge multiple pull requests at the same time.
More detail on the GitHub docs:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue

Note that this has been activated on master.
Update GitHub Actions workflow for merge queue
- Change binary export to single-precision floating-point.
- Change binary export to big-endian.
- Support import of both little-endian and big-endian data.
Closes #2593.
Commit e4b3530 was supposed to include this change, but while write was made independent of the width of default_type, it was erroneously hard-wired to double-precision rather than single.
Replaces both d5767a7 and ebb35a5.
The latter broke functionality of use of command-line option substrings, as discvered by failing CI in #2629.
App::get_matches(): Fix buffer overrun
Mesh::load_vtk() always open files in binary mode
If path to output weights file is erroneous, do not issue a misleading warning message claiming that the issue relates to an inability to allocate memory.
Fixes bug introduced in #626.
Solves #2668.
Replaces #2671.
tcksift2: Fix check for allocation of memory for weights vector
Conflicts:
	src/gui/mrview/tool/tractography/track_scalar_file.h
	src/surface/mesh.cpp
	testing/binaries/data
@Lestropie Lestropie self-assigned this Jul 6, 2023
@Lestropie
Copy link
Member Author

@MRtrix3/mrtrix3-devs Anyone help with the mac CI failure?

@daljit46
Copy link
Member

daljit46 commented Jul 6, 2023

I think it was just a backend issue with homebrew, I reran the test and I think it should pass now.

@jdtournier
Copy link
Member

I think the same thing happened with an earlier PR we merged recently. Re-running the job seemed to work ok then, not sure why it failed the first time...

@daljit46
Copy link
Member

daljit46 commented Jul 6, 2023

It's probably this Homebrew/homebrew-core#135315

@Lestropie Lestropie merged commit 385d590 into dev Jul 6, 2023
@Lestropie Lestropie deleted the master_to_dev branch July 6, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants