Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve changelog by using git-cliff #768

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vjousse
Copy link
Collaborator

@vjousse vjousse commented Sep 24, 2024

🔧 Problem

We can't customize the changelog generated by release-please, so it's impossible to filter technical and non technical changes.

Moreover only fix and feat commits are parts of the changelog, sometimes it would make sense to add chore, refactor and doc changes to the changelog.

🍰 Solution

Try to use git-cliff to generate the changelog and maybe create the tags too.

🚨 Points to watch/comments

This is still an experiment/POC at this stage, I'm not sure that git-cliff fully meets ours needs.

🏝️ How to test

TODO

@vjousse vjousse force-pushed the chore/improve-changelog branch 3 times, most recently from 79c5299 to 1283e08 Compare September 26, 2024 09:50
@vjousse vjousse force-pushed the chore/improve-changelog branch 2 times, most recently from 33e704b to 11f8e9e Compare September 26, 2024 13:45
vjousse added a commit that referenced this pull request Sep 26, 2024
## 🔧 Problem

When deploying on scalingo we download all releases without checking if
it's a draft one, it may cause problems if we want to use the draft
functionality of releases to use `git-cliff` for example
#768.

## 🍰 Solution

Filter out releases that are draft.


## 🏝️ How to test

The deploy to scalingo of this PR should download 11 releases and not
more (we currently have 11 releases and some drafts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant