chore: don't download draft releases #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjousse
changed the title
n1k0
approved these changes
Sep 26, 2024
| with open(local_filename, "wb") as f: | ||
| shutil.copyfileobj(r.raw, f) | ||
| else: | ||
| logger.error(f"Status: {r.status_code}, body: {r.text}") |
| continue | ||
|
|
||
| for asset in release.assets: | ||
| if "-dist.tar.gz" in asset.browser_download_url: | ||
| file_path = download_file( | ||
| asset.browser_download_url, args.destination_directory | ||
| ) | ||
| if not file_path: | ||
| logger.error( | ||
| f"Error downloading {asset.browser_download_url}, skipping." |
As far as I know, sentry as never been enabled on the python side 😬 |
Argh, you're right! Would be nice to be notified when release archives are unavailable or things like that… but I suspect we'd get many errors as it would depend on GH infrastructure availability, which has proven slightly unreliable over time. |
This was referenced Oct 7, 2024
Closed
vjousse
pushed a commit
that referenced
this pull request
Oct 10, 2024
## [2.4.0](https://github.com/MTES-MCT/ecobalyse/compare/v2.3.0..v2.4.0) (2024-10-10) ### 🚀 Features - Introduce first version of object interface ([#756](#756)) ### 🪲 Bug Fixes - Sync food ([#759](#759)) - Don't hide version information on staging ([#778](#778)) - Reset physical durablility in regulatory mode ([#786](#786)) - *(api,food)* Nullable fields weren't nullable anymore. ([#789](#789)) ### 🚜 Refactor - Small textile explorer improvements ([#773](#773)) ### ⚙️ Miscellaneous Tasks - Don't download draft releases ([#771](#771)) - Remove `airTransportRatio` from examples ([#785](#785)) - Cleanup package-lock.json. ([#787](#787)) - Use builtin python action cache for pipenv ([#796](#796)) - Improve changelog by using `git-cliff` ([#768](#768)) <!-- generated by git-cliff --> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Problem
When deploying on scalingo we download all releases without checking if it's a draft one, it may cause problems if we want to use the draft functionality of releases to use
git-clifffor example #768.🍰 Solution
Filter out releases that are draft.
🏝️ How to test
The deploy to scalingo of this PR should download 11 releases and not more (we currently have 11 releases and some drafts).