Redesign "Edit lecture" page #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #595 from MaMpf-HD/dev
Merge pull request #601 from MaMpf-HD/dev
Merge pull request #604 from MaMpf-HD/dev
Merge pull request #605 from MaMpf-HD/dev Annotation Tool 🙌
Merge pull request #608 from MaMpf-HD/dev
See the upgrade guide here: https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html
See https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#config-autoload-lib-and-config-autoload-lib-once Eager loading is on by default for production.
The file `config/app_environment_variables.rb` does not exist in our codebase anymore.
This was done because `bin/rails app:update` failed with:
** Execute app:update:active_storage
rails active_storage:update
bin/rails aborted!
Gem::LoadError: can't activate listen (~> 3.5), already activated listen-3.0.8.
Make sure all dependencies are added to Gemfile.
In this process, I regenerated the `Gemfile.lock` by deleting it, then rebuilding it with bundler via `bundle install`. Some minor versions were upgraded.
You can do so locally via `bundle update --bundler`
Performed automatically via `bundle install`.
This is a followup to rails/rails#47463
`bundle install` also removed globalize automatically for us.
`cypress_folder` is deprecated as config option
|
closed in favor of #628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠ Merge #609 beforehand.
Current preview:
