Redesign lecture edit page for lecturers #628
Conversation
See the upgrade guide here: https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html
See https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#config-autoload-lib-and-config-autoload-lib-once Eager loading is on by default for production.
The file `config/app_environment_variables.rb` does not exist in our codebase anymore.
This was done because `bin/rails app:update` failed with:
** Execute app:update:active_storage
rails active_storage:update
bin/rails aborted!
Gem::LoadError: can't activate listen (~> 3.5), already activated listen-3.0.8.
Make sure all dependencies are added to Gemfile.
In this process, I regenerated the `Gemfile.lock` by deleting it, then rebuilding it with bundler via `bundle install`. Some minor versions were upgraded.
You can do so locally via `bundle update --bundler`
Performed automatically via `bundle install`.
This is a followup to rails/rails#47463
`bundle install` also removed globalize automatically for us.
`cypress_folder` is deprecated as config option
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
I think the the behaviour concerning where you land after having saved some changes should be more uniform. Also, I think that since the tabs are now way more easily accesible, the default should be that after having saved something, one should stay in the tab instead of being placed in the content tab.
- If I change something in the "Preferences" tab, there appears a "Save and Exit"-Button and I land back in the content tab ( I would probably prefer a "Save" button and would want to remain in the "preferences" tab).
- In the "People/Tutorials" tab, if I add an editor, there appears a "Save" button, which then takes me back to the "Content" tab (again, I would prefer to remain in the tab). If I add a tutorial, I remain in the tab.
- In the "Orga" tab, a "Save and Exit" button appears and takes me back to the "Content" tab.
- In the "Communication" tab, most of the actions you can do will let you stay in the tab, only the checkbox and radiobutton will produce "Save and Exit" buttons that take you back to the "Content" tab.
- In the "Assignments" tab, creating an assignment lets you stay in the tab, making other changes take you out of it.
- In the "Info" tab, there is a "Save" button even if nothing was changed (in contrast to the behaviour in the other tabs).
Another thing that I noticed is that the use of the "back" and "forward"-buttons of the browser is somehow broken (sometimes you land at unexpected pages, sometimes they just dont do anything). Probably a turbolinks issue.
|
Thanks for the review. I've addressed all your points in the last commits.
|
There was a problem hiding this comment.
LGTM, I played around with it for some time. I only stumbled upon one very strange bug involving the navigation of the navbar headers by Tab and arrow keys. If you make use of that and return to the content tab, the layout for the content tab is suddenly broken.
I've listened to the wrong event listener, see the correct ones here. I'm now listening to |
Current preview:
TODO
CancelbuttonSave&CancelbuttonsCommentssave button not saving any changes (it even triggers an exception)For reviewers
Sorry for the over 1,000 line insertions/deletions in this PR. This is mainly due to having migrated the
lectures.coffeefile tolectures.jsand due to copying/pasting some old content to new locations while also modifying it, such that Git does not recognize it as replacements and instead deletions/insertions.