Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign lecture edit page for lecturers #628

Merged
merged 74 commits into from
May 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
fd44232
Upgrade Rails to v7.1 and run `bundle update`
Splines Apr 6, 2024
456ed14
Use older version of `html-parser` for `thredded`
Splines Apr 6, 2024
6aee7bb
Use new `config.autoload_lib` in Rails 7.1
Splines Apr 6, 2024
97ea0da
Remove unused app environment variables usage
Splines Apr 6, 2024
e066740
Run `bin/rails app:update` to update configurations
Splines Apr 6, 2024
1236c1b
Add new framework defaults for Rails 7.1 file
Splines Apr 6, 2024
b5cb411
Update `listen` gem version
Splines Apr 6, 2024
0aa94e8
Add TODO note for upcoming serialize change
Splines Apr 6, 2024
2988751
Reduce new framework defaults list
Splines Apr 6, 2024
8d5486d
Add migrations introduced by rails update task
Splines Apr 6, 2024
889e291
Remove unneeded ActiveStorage migrations
Splines Apr 7, 2024
16a33b1
Remove defaults for sha-256 as we are unaffected
Splines Apr 7, 2024
334d7f0
Merge branch 'dev' into deps/upgrade-rails
Splines Apr 9, 2024
5d37d16
Use new Rails 7.1 defaults
Splines Apr 9, 2024
826a800
Fix TODO rubocop warning
Splines Apr 9, 2024
27cd996
Merge branch 'dev' into deps/upgrade-rails & update
Splines Apr 16, 2024
ab6143d
Update bundler version to 2.5.9
Splines Apr 16, 2024
3035022
Merge branch 'dev' into deps/upgrade-rails
Splines Apr 17, 2024
7f97403
Remove unnecessary entries in `Gemfile.lock`
Splines Apr 17, 2024
2b17c87
Address `Passing the coder as positional arg` deprecation
Splines Apr 22, 2024
59c023e
add yaml coder explicitly for serializing arrays
fosterfarrell9 Apr 23, 2024
64fba87
Migrate from globalize to mobility due to serialization warnings
fosterfarrell9 Apr 23, 2024
d695188
Update gem lockfile to include `mobility`
Splines Apr 24, 2024
2c0e7d7
Merge branch 'dev' into deps/upgrade-rails
Splines Apr 24, 2024
f486935
Add `I18nLocaleAccessors` as replacement for `globalize_attribute_names`
Splines Apr 24, 2024
fe65192
Remove obsolete comment regarding `globalize`
Splines Apr 24, 2024
4b8ad59
Fix Rails `secrets` deprecation warning (Devise)
Splines Apr 24, 2024
652f8be
Use `install_folder` in cypress on rails
Splines Apr 24, 2024
b192dd6
Init dummy Bootstrap nav pills
Splines Apr 25, 2024
04f6650
Group accordion items into nav pane
Splines Apr 25, 2024
003b3cb
Style pillars & improve accessibility
Splines Apr 25, 2024
3ced2a7
Remove accordion wrappers & design lecture content pane
Splines Apr 25, 2024
8514c31
Center lectures header & improve vertical alignment
Splines Apr 25, 2024
b53f804
Merge branch 'dev' into feature/admin-lecture-edit-redesign
Splines Apr 26, 2024
1aa1104
Merge branch 'dev' into feature/admin-lecture-edit-redesign
Splines Apr 27, 2024
01f2893
Merge branch 'dev' into feature/admin-lecture-edit-redesign
Splines May 7, 2024
7796302
Add margin to bottom of lecture pane
Splines May 7, 2024
8df2d5c
Internationalize lectures navbar headers
Splines May 7, 2024
9218cd3
Decaffeinate `lectures.coffee`
Splines May 7, 2024
d4b2b01
Format `lectures.js` according to ESLint
Splines May 7, 2024
a248ad7
Remove unnecessary use of Array.from
Splines May 7, 2024
7065b38
Use shorter variations of null checks
Splines May 7, 2024
4a8f7ad
Remove unnecessary Coffeescript comment
Splines May 7, 2024
4bbcd38
Fix ESLint errors
Splines May 7, 2024
55ce0f3
Make better use of JS function syntax
Splines May 7, 2024
f2f63d7
Configure url hashes for bootstrap tabs
Splines May 7, 2024
e08d8a9
Simplify url hash update logic
Splines May 7, 2024
8a34b45
Remove unused variable `s`
Splines May 7, 2024
c15b47c
Use focus listener (not click listener) for accessibility
Splines May 7, 2024
98c068e
Implement many small UI improvements in lectures
Splines May 7, 2024
30c3e82
Re-initialize masonry grid system for lecture content
Splines May 7, 2024
b2b68bd
Remove unnecessary spacing
Splines May 7, 2024
0837131
Add confirmation dialog to delete forum
Splines May 7, 2024
2186f2e
Add scrollbar to announcements list if too long
Splines May 8, 2024
a30b373
Redirect to correct page after creating a new announcement
Splines May 8, 2024
1eb3b04
Redirect to correct page after "Forum" actions
Splines May 8, 2024
acd7e40
Redirect to correct page after "Comments" actions
Splines May 8, 2024
b766555
Merge branch 'dev' into feature/admin-lecture-edit-redesign
Splines May 13, 2024
3d66c04
Increase bottom margin of lecture pane
Splines May 14, 2024
2455ba1
Check if errors are present to avoid nil error
Splines May 14, 2024
8ddc333
Fix valid_annotations_status include check
Splines May 14, 2024
c9b157b
Only load lectures_admin js related code when needed
Splines May 14, 2024
132d128
Use icons for save/cancel in assignments table
Splines May 14, 2024
635c93d
Fix structures cancel button (erdbeere)
Splines May 15, 2024
02273ad
Improve positioning of "structures" text
Splines May 15, 2024
01593c9
Get rid of unused debug message
Splines May 15, 2024
cddf401
Fix import of media for lectures not working
Splines May 22, 2024
d628118
Remove TODO note
Splines May 22, 2024
6ea1e75
Delete unused tags/modal partial rendering
Splines May 27, 2024
75d6074
Stay on subpage upon save action
Splines May 27, 2024
c18c46e
Fix broken browser navigation
Splines May 27, 2024
98e80d8
Fix weird masonry grid system bug
Splines May 28, 2024
bff3aa3
Merge branch 'dev' into feature/admin-lecture-edit-redesign
Splines May 28, 2024
bb81fb1
Wait until tab content is shown before setting up grid system
Splines May 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .config/eslint.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const customGlobals = {

// Common global methods
initBootstrapPopovers: "readable",
initMasonryGridSystem: "readable",

// Thyme & Annotation tool globals
// TODO: This is a "hack" right now to get rid of "xy is not defined" error
Expand Down
1 change: 1 addition & 0 deletions app/assets/javascripts/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
//= require lectures
//= require lessons
//= require main
//= require masonry_grid
//= require media
//= require notifications
//= require profile
Expand Down
351 changes: 0 additions & 351 deletions app/assets/javascripts/lectures.coffee

This file was deleted.

Loading