Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person joining #1

Closed
bill88t opened this issue Dec 14, 2020 · 5 comments
Closed

Person joining #1

bill88t opened this issue Dec 14, 2020 · 5 comments
Assignees

Comments

@bill88t
Copy link

bill88t commented Dec 14, 2020

If a person joins after the start button is pressed the entire plugin bugs out.

@Maartii Maartii self-assigned this Dec 14, 2020
@Maartii
Copy link
Owner

Maartii commented Dec 14, 2020

Thanks for opening an issue here!

What do you see when a person joins after the start button? When I tried to reproduce it I found that one player gets a message that they will 'be jester (unless they'll be impostor)', but they (likely) never become jester after that. That on itself is a bug that would be good to fix, so will try to do that soon. Does anything else happen for you when someone joins after clicking the start button?

@bill88t
Copy link
Author

bill88t commented Dec 15, 2020

Start button is pressed
OPEN CHAT is visible
person joins
Start button is pressed
we eject the jester #1
Hats appear game doesn't end
we eject jester #2
hats don't appear game continues
we eject impostor
chat says jester won
plugin won't end any games until we make a new lobby

@Maartii
Copy link
Owner

Maartii commented Dec 16, 2020

Thanks for the explanation. Not entirely sure what's causing it, but will try to fix it as soon as possible.

@Maartii Maartii pinned this issue Dec 16, 2020
@Maartii
Copy link
Owner

Maartii commented Dec 17, 2020

@bill88t

Tried to fix this in the new version. Could you maybe try to use the new version of the plugin (1.1.1) with the latest experimental version of the Impostor server? (current version is 1.2.2-ci.123, you can find it at https://ci.appveyor.com/project/Impostor/Impostor/branch/dev/artifacts)

As of now, it still doesn't work when you press start again while 'OPEN CHAT' is still visible. But if you press the start button after that it should (hopefully) be fine, let me know how it goes.

@bill88t
Copy link
Author

bill88t commented Dec 17, 2020

Sure, me and my friends will most likely gather tonight. We will play it.

@Maartii Maartii closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants