Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Symmetric mul! for GPUs #201

Merged
merged 10 commits into from
Aug 18, 2022
Merged

[hotfix] Symmetric mul! for GPUs #201

merged 10 commits into from
Aug 18, 2022

Conversation

sshin23
Copy link
Member

@sshin23 sshin23 commented Aug 16, 2022

Same as #198, but applied for GPU and some other dense kkt functions

@sshin23 sshin23 requested a review from frapac August 16, 2022 20:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #201 (4de5b22) into master (185c525) will increase coverage by 0.13%.
The diff coverage is 97.22%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   74.31%   74.45%   +0.13%     
==========================================
  Files          38       38              
  Lines        3637     3664      +27     
==========================================
+ Hits         2703     2728      +25     
- Misses        934      936       +2     
Impacted Files Coverage Δ
lib/MadNLPHSL/src/MadNLPHSL.jl 90.00% <ø> (ø)
lib/MadNLPKrylov/src/MadNLPKrylov.jl 0.00% <0.00%> (ø)
lib/MadNLPPardiso/src/MadNLPPardiso.jl 100.00% <ø> (ø)
lib/MadNLPPardiso/src/pardiso.jl 0.00% <0.00%> (ø)
src/IPM/utils.jl 89.83% <ø> (-2.36%) ⬇️
src/MadNLP.jl 57.14% <ø> (ø)
lib/MadNLPHSL/src/ma27.jl 84.05% <100.00%> (ø)
lib/MadNLPHSL/src/ma57.jl 83.82% <100.00%> (ø)
lib/MadNLPHSL/src/ma77.jl 96.29% <100.00%> (ø)
lib/MadNLPHSL/src/ma86.jl 94.73% <100.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sshin23
Copy link
Member Author

sshin23 commented Aug 18, 2022

symul! function is added to dispatch to BLAS.symv! or CUBLAS.symv! depending on the input

Copy link
Collaborator

@frapac frapac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks good for me!

lib/MadNLPGPU/src/MadNLPGPU.jl Show resolved Hide resolved
@sshin23 sshin23 merged commit 87f4e0b into master Aug 18, 2022
@frapac frapac deleted the ss/condensed_mul_hotfix branch April 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants