Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for pattern matching #96

Merged

Conversation

antonagestam
Copy link
Contributor

Closes #95.

@antonagestam antonagestam force-pushed the feature/support-pattern-matching branch 7 times, most recently from 7d8a258 to 7ecc534 Compare November 18, 2022 21:13
@antonagestam antonagestam marked this pull request as draft November 18, 2022 21:15
@antonagestam antonagestam force-pushed the feature/support-pattern-matching branch from 7ecc534 to 2a34114 Compare November 18, 2022 21:22
Comment on lines +3418 to +3420
#ifdef Py_TPFLAGS_MAPPING
| Py_TPFLAGS_MAPPING
#endif
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I am not a C developer. I noticed errors for this name not being available on <3.10, and scrambled this together. Please let me know if this is not how things are done, or if you think the formatting looks off.

@antonagestam antonagestam force-pushed the feature/support-pattern-matching branch from 2a34114 to 7904cc8 Compare November 18, 2022 21:29
@antonagestam antonagestam marked this pull request as ready for review November 18, 2022 21:30
@antonagestam
Copy link
Contributor Author

Tests are failing on 3.11 on macos, however I believe it's not related to my changes.

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elprans elprans merged commit 7071a24 into MagicStack:master Nov 18, 2022
@antonagestam antonagestam deleted the feature/support-pattern-matching branch November 18, 2022 21:49
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
@elprans elprans mentioned this pull request Aug 14, 2023
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pattern matching isn't working for C implementation
2 participants