Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore compilation for aix/sunos #98

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

mattp-
Copy link
Contributor

@mattp- mattp- commented Feb 2, 2023

the CFLAGs being tacked on aren't compatible on those platforms, I've tried to add the equivalent. signed-char is the default on sunstudio as such have left it unadded.

the CFLAGs being tacked on aren't compatible on those platforms, I've
tried to add the equivalent. signed-char is the default on sunstudio as
such have left it unadded.
@mattp- mattp- changed the title add support for aix/sunos restore compilation for aix/sunos Feb 2, 2023
@mattp-
Copy link
Contributor Author

mattp- commented Feb 3, 2023

unsure why these checks are failing, I don't think its related to my change

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@elprans elprans merged commit 765e4ee into MagicStack:master Jul 21, 2023
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
@elprans elprans mentioned this pull request Aug 14, 2023
elprans added a commit that referenced this pull request Aug 14, 2023
Changes
=======

* Enable support for pattern matching (#96)
  (by @antonagestam in 7071a24 for #96)

* add support for aix/sunos (#98)
  (by @mattp- in 765e4ee for #98)

* Python 3.12 compatibility (#105)
  (by @elprans in f797822 for #105)

* Add __contains__ to MapKeys (#99)
  (by @msullivan in 6790111 for #99)

* Add PEP 585 GenericAlias support (#101)
  (by @eltoder in 9ce64c5 for #101)

* Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111)
  (by @elprans in ea65656 for #111)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants