Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactivity of GLMakie plots lost after save #2380

Closed
fatteneder opened this issue Oct 27, 2022 · 6 comments
Closed

Interactivity of GLMakie plots lost after save #2380

fatteneder opened this issue Oct 27, 2022 · 6 comments
Labels
GLMakie This relates to GLMakie.jl, the OpenGL backend for Makie.

Comments

@fatteneder
Copy link
Contributor

MWE

using GLMakie
GLMakie.activate!()

f = Figure()
ax = Axis(f[1,1])
lines!(ax, 1:5, 1:5)
display(f)

Running the above gives an interactive plot (e.g. rectangle zoom, scroll zoom, drag pane, reset limits etc.)

If you then run save("test.png", f) in the same REPL a nice png is generated. However, if you switch back to the GLMakie window you notice that neither rectangle zoom nor dragging nor reset limits work anymore, only scroll zoom works.

Problem appears on [email protected] and [email protected].
@SimonDanisch
Copy link
Member

Ah jeez...Seems like my "better clean up" was quite destructive after all -.-

@fatteneder
Copy link
Contributor Author

This is fixed by #2367 or?

@SimonDanisch
Copy link
Member

I think so...

@fatteneder
Copy link
Contributor Author

Just checked, its fixed on master.

@fatteneder
Copy link
Contributor Author

Wait. What works is

  • Run above mwe.jl
  • Run save("mwe.png", f) -> Saves png but the window is not interactable.
  • Run display(f) to gain interactivity again.

Not sure if that was also how it worked before v0.18.0? I will test quickly.

@fatteneder
Copy link
Contributor Author

Ok. On v0.17.13 you did not need the extra display(f) to regain interactivity.

@SimonDanisch SimonDanisch reopened this Nov 2, 2022
@SimonDanisch SimonDanisch added the GLMakie This relates to GLMakie.jl, the OpenGL backend for Makie. label Nov 3, 2022
SimonDanisch added a commit that referenced this issue Nov 3, 2022
@SimonDanisch
fix #2380
f99b5ae
@SimonDanisch SimonDanisch mentioned this issue Nov 3, 2022
Merged
@haakon-e haakon-e mentioned this issue Nov 16, 2022
Closed
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this issue Dec 31, 2022
@SimonDanisch @ffreyer @t-bltg
GLMakie cleanups (MakieOrg#2397)
fba4614 
* prototyping

* track vertexarray buffers

* track Texture updates

* remove prints

* add new renderloop

* cleanup

* remove :inspectable from uniforms

* update NEWS

* only track updates when render_on_demand = true

* move visible to struct & fix rerender on visible

* fix visible initialization

* free robjs correctly in empty

* better observable clean up

* fix MakieOrg#2380

* fix faulty uniforms

* make sure we actually error for OpenGL errors

* new observables

* check for extension before setting

* fix remaining clean up issues

* fix tests

* not all have shading

* fxaa

* clean up screen handling + destroy!

* fix tests

* fix WGLMakie + CairoMakie tests

* didn't correctly forward visibility attributes

* bump timeout

* clean up compile

* 🤷

* fix method overwrite

* revert updating only when not displayed yet

* correctly implement getscreen

* disable test for now

* fix tests

* forgot overload

* fixes for WGLMakie

* fix RPRMakie

* lol

* fix matcap

* Update NEWS.md

Co-authored-by: ffreyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GLMakie This relates to GLMakie.jl, the OpenGL backend for Makie.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonDanisch @fatteneder