-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLMakie cleanups #2397
GLMakie cleanups #2397
Conversation
Ok, I have no idea, what the GLMakie regression in compile times is about... |
…into sd/gl-cleanups
* prototyping * track vertexarray buffers * track Texture updates * remove prints * add new renderloop * cleanup * remove :inspectable from uniforms * update NEWS * only track updates when render_on_demand = true * move visible to struct & fix rerender on visible * fix visible initialization * free robjs correctly in empty * better observable clean up * fix MakieOrg#2380 * fix faulty uniforms * make sure we actually error for OpenGL errors * new observables * check for extension before setting * fix remaining clean up issues * fix tests * not all have shading * fxaa * clean up screen handling + destroy! * fix tests * fix WGLMakie + CairoMakie tests * didn't correctly forward visibility attributes * bump timeout * clean up compile * 🤷 * fix method overwrite * revert updating only when not displayed yet * correctly implement getscreen * disable test for now * fix tests * forgot overload * fixes for WGLMakie * fix RPRMakie * lol * fix matcap * Update NEWS.md Co-authored-by: ffreyer <[email protected]>
Should fix #2371 #2392 and #2380...
Based against ff/render_on_demand, since they will likely collide and I also want to add some more low level GLMakie tests, which should also test #2336 for correctness.
Needs: JuliaGizmos/Observables.jl#92 for
clear
(could have added that in Makie directly, but I want to be more strict with adding functions to the correct package, and I really need to actually merge & tag JuliaGizmos/Observables.jl#92).