Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLMakie cleanups #2397

Merged
merged 48 commits into from
Nov 10, 2022
Merged

GLMakie cleanups #2397

merged 48 commits into from
Nov 10, 2022

Conversation

SimonDanisch
Copy link
Member

Should fix #2371 #2392 and #2380...
Based against ff/render_on_demand, since they will likely collide and I also want to add some more low level GLMakie tests, which should also test #2336 for correctness.
Needs: JuliaGizmos/Observables.jl#92 for clear (could have added that in Makie directly, but I want to be more strict with adding functions to the correct package, and I really need to actually merge & tag JuliaGizmos/Observables.jl#92).

@SimonDanisch SimonDanisch marked this pull request as ready for review November 4, 2022 13:52
@SimonDanisch SimonDanisch reopened this Nov 4, 2022
@SimonDanisch SimonDanisch reopened this Nov 4, 2022
@SimonDanisch SimonDanisch changed the base branch from ff/render_on_demand to master November 4, 2022 14:27
@SimonDanisch SimonDanisch reopened this Nov 4, 2022
@SimonDanisch SimonDanisch reopened this Nov 7, 2022
GLMakie/src/GLAbstraction/GLTypes.jl Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
@SimonDanisch SimonDanisch mentioned this pull request Nov 9, 2022
@SimonDanisch
Copy link
Member Author

Ok, I have no idea, what the GLMakie regression in compile times is about...
I tried to debug this a bit, but couldn't really pin down what I changed in the PR to make this slow down.
I think we should go for another compile time sprint at some point anyways, so hope to clean them up then.
The WGLMakie runtime regression is likely noise or will be fixed in the new JSServe rewrite.
The CairoMakie speed improvement seems to be real (yay), and seems to come from finally really re-using the screen for drawing :) I've a few ideas about how to speed up GLMakie as well, but that will need to wait for another PR.
I'm going to merge this quickly now, since all the other PRs are hold back by the failing GLMakie tests.
If there are any concerns, we should address them before releasing master!

@SimonDanisch SimonDanisch merged commit 9f767a3 into master Nov 10, 2022
@SimonDanisch SimonDanisch deleted the sd/gl-cleanups branch November 10, 2022 19:12
@SimonDanisch SimonDanisch mentioned this pull request Nov 10, 2022
2 tasks
t-bltg pushed a commit to t-bltg/Makie.jl that referenced this pull request Dec 31, 2022
* prototyping

* track vertexarray buffers

* track Texture updates

* remove prints

* add new renderloop

* cleanup

* remove :inspectable from uniforms

* update NEWS

* only track updates when render_on_demand = true

* move visible to struct & fix rerender on visible

* fix visible initialization

* free robjs correctly in empty

* better observable clean up

* fix MakieOrg#2380

* fix faulty uniforms

* make sure we actually error for OpenGL errors

* new observables

* check for extension before setting

* fix remaining clean up issues

* fix tests

* not all have shading

* fxaa

* clean up screen handling + destroy!

* fix tests

* fix WGLMakie + CairoMakie tests

* didn't correctly forward visibility attributes

* bump timeout

* clean up compile

* 🤷

* fix method overwrite

* revert updating only when not displayed yet

* correctly implement getscreen

* disable test for now

* fix tests

* forgot overload

* fixes for WGLMakie

* fix RPRMakie

* lol

* fix matcap

* Update NEWS.md

Co-authored-by: ffreyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes after close and closeall
3 participants