Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm_reconfigure_request error checking quota's #150

Closed
Stromweld opened this issue Jan 19, 2018 · 7 comments
Closed

vm_reconfigure_request error checking quota's #150

Stromweld opened this issue Jan 19, 2018 · 7 comments
Assignees

Comments

@Stromweld
Copy link

Stromweld commented Jan 19, 2018

A user with only a tenant quota for memory set to 256GB is trying to reconfigure a VM and add an additional HDD to his machine. We are seeing an error in the quota used method when calling check_quota. When the quota is turned off then he is able to provision the drive without error.

We are running MIQ Fine-4 and VMware vcenter 6.5.
Gist contains the logs for the vm_reconfigure_request.
https://gist.github.com/Stromweld/d59742714eda7e732378e262217dd412

@gmcculloug
Copy link
Member

@tinaafitz @billfitzgerald0120 Please review

@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@gmcculloug
Copy link
Member

@billfitzgerald0120 Do you know if this has been resolved?

@billfitzgerald0120
Copy link
Contributor

@gmcculloug Not sure but I will check.

@billfitzgerald0120
Copy link
Contributor

@gmcculloug This is still an issue. When Memory is over quota, the reconfigure request will be denied even if there is no request for more memory. I tried to add just a drive when memory was exceeded and it was denied.

@gmcculloug gmcculloug added pinned and removed stale labels Jul 24, 2018
@gmcculloug
Copy link
Member

Thanks for looking into that @billfitzgerald0120. I'll pin the issue for now.

@billfitzgerald0120
Copy link
Contributor

@gmcculloug I think its a one line change but I want to discuss with Tina in case I'm missing something

billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 25, 2018
…denying quota.

For Vm Reconfigure, If we add a disk it shouldn't deny because memory, cpus or number of vms is exceeded.

Fixes ManageIQ/manageiq-automation_engine#150
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Jul 26, 2018
…denying quota.

For Vm Reconfigure, If we add a disk it shouldn't deny because memory, cpus or number of vms is exceeded.

Fixes ManageIQ/manageiq-automation_engine#150

Updated spec and added 4 new tests.
billfitzgerald0120 added a commit to billfitzgerald0120/manageiq-content that referenced this issue Aug 8, 2018
…denying quota.

For Vm Reconfigure, If we add a disk it shouldn't deny because memory, cpus or number of vms is exceeded.

Fixes ManageIQ/manageiq-automation_engine#150

Updated spec and added 4 new tests.
Created 2 shared examples, one for Provisioning and one for Reconfigure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants