Changed validate_quota method to check individual quota items. #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
billfitzgerald0120
force-pushed
the
quota_reconfig_check_by_item
branch
from
2884c17
to
f19ebde
Compare
|
@tinaafitz Please Review |
mkanoor
reviewed
Aug 2, 2018
| expect(@miq_request.message).to eql(err_msg) | ||
| end | ||
|
|
||
| it "failure max memory" do |
There was a problem hiding this comment.
@billfitzgerald0120 Is this a repeat of previous test from line 159 to 170
mkanoor
reviewed
Aug 2, 2018
| @miq_request.reload | ||
| expect(@miq_request.options[:quota_max_exceeded]).to eql(err_msg) | ||
| expect(@miq_request.message).to eql(err_msg) | ||
| end |
There was a problem hiding this comment.
@billfitzgerald0120 can we make this a shared example and feed different values into it.
There was a problem hiding this comment.
@mkanoor Created 2 shared examples, one for Provisioning and one for Reconfigure
…denying quota. For Vm Reconfigure, If we add a disk it shouldn't deny because memory, cpus or number of vms is exceeded. Fixes ManageIQ/manageiq-automation_engine#150 Updated spec and added 4 new tests. Created 2 shared examples, one for Provisioning and one for Reconfigure
billfitzgerald0120
force-pushed
the
quota_reconfig_check_by_item
branch
from
f19ebde
to
3f26339
Compare
|
Checked commit billfitzgerald0120@3f26339 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@mkanoor Please review |
mkanoor
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vm Reconfigure was failing on quota when a different quota item was exceeded.
For Vm Reconfigure, If we add a disk it shouldn't deny because memory, cpus or number of vm's is exceeded. If we add memory the request should not be denied because of storage, cpus or vm's.
Fixes ManageIQ/manageiq-automation_engine#150