Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAMMER] Update i18n catalog for hammer #141

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

mzazrivec
Copy link

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2018

Checked commits mzazrivec/manageiq-consumption@e90f485~...edcd47a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2018

@himdel can you please review?

@himdel
Copy link

himdel commented Oct 9, 2018

LGTM but the filename is confusing .. ManageIQ_Showback?

Consumption would make more sense...

Copy link

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. but also matches the engine name, so.. not a valid concern here

👍

@simaishi simaishi merged commit 978ff13 into ManageIQ:hammer Oct 9, 2018
@simaishi simaishi added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018
@mzazrivec mzazrivec deleted the update_i18n_catalog_for_hammer branch October 10, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants