[HAMMER] Update i18n catalog for hammer #18040

mzazrivec · 2018-10-01T14:06:30Z

Plugin PRs to be merged with this:

miq-bot · 2018-10-01T14:15:59Z

Checked commits mzazrivec/manageiq@e8ab261~...f2c6c7e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

carbonin · 2018-10-04T17:54:12Z

It looks like a spec related to gettext is failing here. I don't know too much about it, could you take a look @mzazrivec ?

simaishi · 2018-10-05T11:58:26Z

Travis failure:

  1) placeholders gettext strings do not contain interpolations
     Failure/Error: expect(errors).to be_empty
       expected `["\"Cancel operation is not supported for \#{self.class.name}\""].empty?` to return true, got false
     Shared Example Group: :placeholders called from ./spec/i18n/placeholders_spec.rb:2
     # ./spec/shared/i18n/placeholders.rb:49:in `block (2 levels) in <top (required)>'

mzazrivec · 2018-10-08T09:00:25Z

CI fix: #18067

miq-bot changed the title ~~Update i18n catalog for hammer~~ [HAMMER] Update i18n catalog for hammer Oct 1, 2018

simaishi self-assigned this Oct 4, 2018

simaishi added the internationalization label Oct 4, 2018

simaishi requested a review from carbonin October 4, 2018 14:11

mzazrivec mentioned this pull request Oct 8, 2018

Don't use interpolation in gettext strings #18067

Merged

mzazrivec added 2 commits October 8, 2018 15:22

Update zanata.xml for hammer

aa4884e

Update i18n catalog for hammer release

30d30cc

mzazrivec force-pushed the update_i18n_catalog_for_hammer branch from f2c6c7e to 30d30cc Compare October 8, 2018 13:25

carbonin approved these changes Oct 8, 2018

View reviewed changes

simaishi merged commit 1c8bf5d into ManageIQ:hammer Oct 9, 2018

simaishi added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018

mzazrivec deleted the update_i18n_catalog_for_hammer branch October 10, 2018 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HAMMER] Update i18n catalog for hammer #18040

[HAMMER] Update i18n catalog for hammer #18040

mzazrivec commented Oct 1, 2018 •

edited

Loading

miq-bot commented Oct 1, 2018

carbonin commented Oct 4, 2018

simaishi commented Oct 5, 2018

mzazrivec commented Oct 8, 2018

[HAMMER] Update i18n catalog for hammer #18040

[HAMMER] Update i18n catalog for hammer #18040

Conversation

mzazrivec commented Oct 1, 2018 • edited Loading

miq-bot commented Oct 1, 2018

carbonin commented Oct 4, 2018

simaishi commented Oct 5, 2018

mzazrivec commented Oct 8, 2018

mzazrivec commented Oct 1, 2018 •

edited

Loading