Email instances for Infra VM provisioning. #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@billfitzgerald0120 Looks good. |
Added 7 instances in System/Notification/Email class for Infra/VM provisioning. Modified EmailOwner value in 2 State Machine classes and clone_to_vm instance to use new instances. /Infrastructure/VM/Provisioning/StateMachines/VMProvision_Template.class/__class__.yaml /Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/__class__.yaml /Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/clone_to_vm.yaml Modified http to https in body field of instances
billfitzgerald0120
force-pushed
the
email_infra_miqprovision
branch
from
9bfceb6
to
b9ef828
Compare
|
Checked commit billfitzgerald0120@b9ef828 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Closed in favor of #303 |
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 7 instances in System/Notification/Email class for Infra/VM provisioning.
Modified EmailOwner value in 2 State Machine classes and clone_to_vm instance to
use new instances.
/Infrastructure/VM/Provisioning/StateMachines/VMProvision_Template.class/class.yaml
/Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/class.yaml
/Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/clone_to_vm.yaml
https://bugzilla.redhat.com/show_bug.cgi?id=1314871
https://www.pivotaltracker.com/epic/show/3861726