Email instances for Infra VM provisioning. #303
Conversation
| @@ -178,7 +178,7 @@ object: | |||
| datatype: string | |||
| priority: 9 | |||
| owner: | |||
| default_value: "/Infrastructure/VM/Provisioning/Email/MiqProvision_complete?event=template_provisioned" | |||
| default_value: "/System/Notification/Email/InfrastructureMiqProvisionComplete?event=template_provisioned" | |||
There was a problem hiding this comment.
@billfitzgerald0120 Where are we documenting these changes, can we start a google doc and make a not of these changes, so it will help us in migration documentation. Its a value in the class schema and not in individual instance.
| @@ -11,4 +11,4 @@ object: | |||
| - PreProvision: | |||
| value: "/Infrastructure/VM/Provisioning/StateMachines/Methods/PreProvision_Clone_to_VM#${/#miq_provision.source.vendor}" | |||
| - EmailOwner: | |||
| value: "/Infrastructure/VM/Provisioning/Email/MiqProvision_Complete?event=vm_cloned" | |||
| value: "/System/Notification/Email/InfrastructureMiqProvisionComplete?event=vm_cloned" | |||
There was a problem hiding this comment.
@tinaafitz
do you know if the event is needed when calling the method, is it used by the called instance or any other child of the called instance.
| @@ -0,0 +1,18 @@ | |||
| --- | |||
There was a problem hiding this comment.
@billfitzgerald0120
Is there a state machine step that calls this instance, should that be attached to this PR?
| value: 'Request ID ${/#miq_provision.miq_request.id} - Your Virtual Machine | ||
| Request has Completed - Vm Name: <${/#miq_provision.vm.name}>' | ||
| - customize: | ||
| value: miq_provision_complete |
There was a problem hiding this comment.
@billfitzgerald0120
Should this be the new customize body method?
Added 7 instances in System/Notification/Email class for Infra/VM provisioning. Modified EmailOwner value in 2 State Machine classes and clone_to_vm instance to use new instances. /Infrastructure/VM/Provisioning/StateMachines/VMProvision_Template.class/class.yaml /Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/class.yaml /Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/clone_to_vm.yaml Removed singles quotes and changed method to miq_provision_custom_body
billfitzgerald0120
force-pushed
the
email2_infra_miqprovision
branch
from
138d4c1
to
e0e9255
Compare
|
Checked commit billfitzgerald0120@e0e9255 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label enhancement |
Added 7 instances in System/Notification/Email class for Infra/VM provisioning.
Modified EmailOwner value in 2 State Machine classes and clone_to_vm instance to
use new instances.
/Infrastructure/VM/Provisioning/StateMachines/VMProvision_Template.class/class.yaml
/Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/class.yaml
/Infrastructure/VM/Provisioning/StateMachines/VMProvision_VM.class/clone_to_vm.yaml
https://bugzilla.redhat.com/show_bug.cgi?id=1314871
https://www.pivotaltracker.com/epic/show/3861726