Remove use of iteritems method #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings this module inline with requirements for Python 3
|
|
@syncrou 'carbonin' is an invalid assignee, ignoring... |
|
@billfitzgerald0120 would you be able to test this on a RHEL 8 appliance? |
|
Checked commit syncrou@ff7633e with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
Pull Request Test Coverage Report for Build 3406
💛 - Coveralls |
|
Will this cause a problem with the ManageIQ appliance which is still running CentOS 7 (and thus python2)? |
|
Closing. Per @carbonin's comment. Will need to validate all changes are backwards compatible with Python 2 and 3. |
|
Closed in favor of #557 also test for backwards compatibility with Python 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings this module inline with requirements for Python 3
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1736116