Changes for Python 3 compatibility (CFME 5.11/RHEL8) #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit pemcg@e302d69 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Some overlap with #556. |
|
Associated BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1738542 |
Pull Request Test Coverage Report for Build 3408
💛 - Coveralls |
syncrou
approved these changes
Aug 9, 2019
simaishi
pushed a commit
that referenced
this pull request
Aug 12, 2019
…ility Changes for Python 3 compatibility (CFME 5.11/RHEL8) (cherry picked from commit 805a31b) https://bugzilla.redhat.com/show_bug.cgi?id=1738542
|
Ivanchuk backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be the bare minimum changes needed to get the manageiq-automate role working in CFME 5.11 on RHEL8 ( Python3).
https://docs.python.org/3.0/whatsnew/3.0.html describes the changes, but suggests that some constructs may be better re-worked to be optimised for Python 3. I haven't done that.
https://bugzilla.redhat.com/show_bug.cgi?id=1738542