Handle possibility of arrays for Network Security Groups

[djberg96]

This handles an api-version update for Network Security Groups that started with api-version 2017-10-01. As of that date, multiple ports and/or ranges are returned as an array with a slightly different property name, e.g. source_address_prefixes instead of source_address_prefix.

For earlier versions of the api-version, it's possible neither property will exist (it doesn't handle arrays), in which case we simply return nil.

Note that for port and end_port I simply took the low and high values, respectively, since the underlying firewall_rules table isn't designed to handle arrays of values.

https://bugzilla.redhat.com/show_bug.cgi?id=1520196

[miq-bot]

Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/19f2a5466cfdc2e14208020dabfda8434e68ad4f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 5 offenses detected

app/models/manageiq/providers/azure/network_manager/refresh_parser.rb

• ❗ - Line 298, Col 5 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 307, Col 55 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• ❗ - Line 308, Col 5 - Style/EmptyElse - Redundant else-clause.
• ❗ - Line 317, Col 55 - Style/SpaceBeforeBlockBraces - Space missing to the left of {.
• ❗ - Line 318, Col 5 - Style/EmptyElse - Redundant else-clause.

[djberg96]

@bronaghs @blomquisg Contrary to what the github is showing, Travis appears to be green.

https://travis-ci.org/ManageIQ/manageiq-providers-azure/builds/311514446?utm_source=github_status&utm_medium=notification

[juliancheal]

🍏 :)

[agrare]

👍

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 9e978a567330939aed11c3dca1bb2c36e2a1790a
Author: Adam Grare <[email protected]>
Date:   Tue Dec 5 09:38:30 2017 -0500

    Merge pull request #180 from djberg96/network_security_groups
    
    Handle possibility of arrays for Network Security Groups
    (cherry picked from commit 41eb3c470ff19476b422701eadb8bee194695e40)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1520977

[simaishi]

Fine backport details:

$ git log -1
commit 5f9fa811e493d3deb9ce71c0e1675d12990673e1
Author: Adam Grare <[email protected]>
Date:   Tue Dec 5 09:38:30 2017 -0500

    Merge pull request #180 from djberg96/network_security_groups
    
    Handle possibility of arrays for Network Security Groups
    (cherry picked from commit 41eb3c470ff19476b422701eadb8bee194695e40)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1521036

[simaishi]

Euwe backport (to manageiq repo) details:

$ git log -1
commit 8f56fc86c5b4d5b10bc6354c8bfb3bc37c6447a8
Author: Adam Grare <[email protected]>
Date:   Tue Dec 5 09:38:30 2017 -0500

    Merge pull request #180 from djberg96/network_security_groups
    
    Handle possibility of arrays for Network Security Groups
    (cherry picked from commit 41eb3c470ff19476b422701eadb8bee194695e40)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1521043