Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle possibility of arrays for Network Security Groups #180

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Handle possibility of arrays for Network Security Groups #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions app/models/manageiq/providers/azure/network_manager/refresh_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,15 +281,45 @@ def parse_firewall_rules(security_group)
{
:name => rule.name,
:host_protocol => rule.properties.protocol.upcase,
:port => rule.properties.destination_port_range.split('-').first,
:end_port => rule.properties.destination_port_range.split('-').last,
:port => calculate_start_port(rule),
:end_port => calculate_end_port(rule),
:direction => rule.properties.direction,
:source_ip_range => rule.properties.source_address_prefix,
:source_ip_range => calculate_source_ip_range(rule),
:source_security_group => @data_index.fetch_path(:security_groups, security_group.id)
}
end
end

def calculate_source_ip_range(rule)
if rule.properties.respond_to?(:source_address_prefix)
rule.properties.source_address_prefix
elsif rule.properties.respond_to?(:source_address_prefixes)
rule.properties.source_address_prefixes.join(',')
else
nil # Old api-version
end
end

def calculate_start_port(rule)
if rule.properties.respond_to?(:destination_port_range)
rule.properties.destination_port_range.split('-').first.to_i
elsif rule.properties.respond_to?(:destination_port_ranges)
rule.properties.destination_port_ranges.flat_map{ |e| e.split('-') }.map(&:to_i).min
else
nil # Old api-version
end
end

def calculate_end_port(rule)
if rule.properties.respond_to?(:destination_port_range)
rule.properties.destination_port_range.split('-').last.to_i
elsif rule.properties.respond_to?(:destination_port_ranges)
rule.properties.destination_port_ranges.flat_map{ |e| e.split('-') }.map(&:to_i).max
else
nil # Old api-version
end
end

def parse_load_balancer(lb)
name = lb.name
uid = lb.id
Expand Down