Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HAMMER] Update i18n catalog for hammer #295

Merged
merged 2 commits into from
Oct 12, 2018
Merged

[HAMMER] Update i18n catalog for hammer #295

merged 2 commits into from
Oct 12, 2018

Conversation

mzazrivec
Copy link
Contributor

No description provided.

@mzazrivec mzazrivec mentioned this pull request Oct 3, 2018
Merged
@simaishi simaishi self-assigned this Oct 4, 2018
@simaishi
Copy link
Contributor

simaishi commented Oct 5, 2018

Travis failure:

  1) placeholders gettext strings do not contain interpolations
     Failure/Error: expect(errors).to be_empty
       expected `["\"Memory Limit is supported for RHV 4.1 and above. Current provider version is \#{ems.api_version}.\""].empty?` to return true, got false
     Shared Example Group: :placeholders called from ./spec/i18n/placeholders_spec.rb:2
     # ./spec/manageiq/spec/shared/i18n/placeholders.rb:49:in `block (2 levels) in <top (required)>'

@pkliczewski
Copy link
Contributor

@simaishi I asked @borod108 to take a look. Maybe we are missing a backport.

@mzazrivec
Copy link
Contributor Author

CI fix: #297

@pkliczewski
Copy link
Contributor

@borod108 Please take a look at the build failure.

@simaishi simaishi closed this Oct 9, 2018
@simaishi simaishi reopened this Oct 9, 2018
@simaishi simaishi closed this Oct 9, 2018
@simaishi simaishi reopened this Oct 9, 2018
@mzazrivec mzazrivec force-pushed the update_i18n_catalog_for_hammer branch from 0c9e1e4 to 720f1ef Compare October 10, 2018 07:12
@miq-bot
Copy link
Member

miq-bot commented Oct 12, 2018

Checked commits mzazrivec/manageiq-providers-ovirt@aaa249a~...720f1ef with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@simaishi simaishi merged commit fd3f41a into ManageIQ:hammer Oct 12, 2018
@simaishi simaishi added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 12, 2018
@mzazrivec mzazrivec deleted the update_i18n_catalog_for_hammer branch October 15, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkliczewski pkliczewski pkliczewski approved these changes

Assignees

@simaishi simaishi

Labels
internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzazrivec @simaishi @pkliczewski @miq-bot