Skip to content
This repository has been archived by the owner on Jul 25, 2023. It is now read-only.

[HAMMER] Update i18n catalog for hammer #90

Merged
merged 2 commits into from
Oct 9, 2018

Conversation

mzazrivec
Copy link
Contributor

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Oct 3, 2018

Checked commits mzazrivec/manageiq-providers-scvmm@918c087~...7128abb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@bronaghs
Copy link

bronaghs commented Oct 4, 2018

I am probably not the best person to review this, @mzazrivec can you suggest another reviewer that is familiar with the i18n efforts?

@mzazrivec
Copy link
Contributor Author

@himdel could review this, perhaps?

Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(assuming no actual translations yet is a known issue :))

@mzazrivec
Copy link
Contributor Author

Yes, the actual translations will land in the git later.

@simaishi simaishi merged commit bb67c50 into ManageIQ:hammer Oct 9, 2018
@simaishi simaishi added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018
@mzazrivec mzazrivec deleted the update_i18n_catalog_for_hammer branch October 10, 2018 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants