-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed API call to pass in region number get list of repos/playbooks #1354
Merged
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:pass_region_number_to_playbook_api_call
May 17, 2017
Merged
Changed API call to pass in region number get list of repos/playbooks #1354
dclarizio
merged 1 commit into
ManageIQ:master
from
h-kataria:pass_region_number_to_playbook_api_call
May 17, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
pass_region_number_to_playbook_api_call
branch
2 times, most recently
from
May 15, 2017 21:36
c30356e
to
1385077
Compare
@gmcculloug ready to test core PR is merged. |
Changed API call to get list of repos/playbooks to pass in current region number so only repos/playbooks in current region are displayed in drop down. https://bugzilla.redhat.com/show_bug.cgi?id=1449696
h-kataria
force-pushed
the
pass_region_number_to_playbook_api_call
branch
from
May 17, 2017 19:01
1385077
to
8b78486
Compare
Checked commit h-kataria@8b78486 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
changed the title
Changed API call to pass in region number get list of playbooks
Changed API call to pass in region number get list of repos/playbooks
May 17, 2017
@dclarizio Validated this is working now. The code was changed to limit repos to the current region. Playbooks are tied to the repo and will be in the same region. |
gmcculloug
approved these changes
May 17, 2017
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
…k_api_call Changed API call to pass in region number get list of repos/playbooks (cherry picked from commit 416407f) https://bugzilla.redhat.com/show_bug.cgi?id=1459986
Fine backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed API call to get list of repos/playbooks to pass in current region number so only playbooks in current region are displayed in drop down.
https://bugzilla.redhat.com/show_bug.cgi?id=1449696
@gmcculloug please test/review. This is dependent on core PR ManageIQ/manageiq#15070