Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed API call to pass in region number get list of repos/playbooks #1354

Merged

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented May 15, 2017

Changed API call to get list of repos/playbooks to pass in current region number so only playbooks in current region are displayed in drop down.

https://bugzilla.redhat.com/show_bug.cgi?id=1449696

@gmcculloug please test/review. This is dependent on core PR ManageIQ/manageiq#15070

@h-kataria
Copy link
Contributor Author

@gmcculloug ready to test core PR is merged.

Changed API call to get list of repos/playbooks to pass in current region number so only repos/playbooks in current region are displayed in drop down.

https://bugzilla.redhat.com/show_bug.cgi?id=1449696
@h-kataria h-kataria force-pushed the pass_region_number_to_playbook_api_call branch from 1385077 to 8b78486 Compare May 17, 2017 19:01
@miq-bot
Copy link
Member

miq-bot commented May 17, 2017

Checked commit h-kataria@8b78486 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@h-kataria h-kataria changed the title Changed API call to pass in region number get list of playbooks Changed API call to pass in region number get list of repos/playbooks May 17, 2017
@gmcculloug
Copy link
Member

@dclarizio Validated this is working now. The code was changed to limit repos to the current region. Playbooks are tied to the repo and will be in the same region.

@dclarizio dclarizio merged commit 416407f into ManageIQ:master May 17, 2017
@dclarizio dclarizio added this to the Sprint 61 Ending May 22, 2017 milestone May 17, 2017
@h-kataria h-kataria deleted the pass_region_number_to_playbook_api_call branch May 18, 2017 17:29
simaishi pushed a commit that referenced this pull request Jun 8, 2017
…k_api_call

Changed API call to pass in region number get list of repos/playbooks
(cherry picked from commit 416407f)

https://bugzilla.redhat.com/show_bug.cgi?id=1459986
@simaishi
Copy link
Contributor

simaishi commented Jun 8, 2017

Fine backport details:

$ git log -1
commit cd41257b3070f7b6118a31759ef13f33155fc8c6
Author: Dan Clarizio <[email protected]>
Date:   Wed May 17 12:54:22 2017 -0700

    Merge pull request #1354 from h-kataria/pass_region_number_to_playbook_api_call
    
    Changed API call to pass in region number get list of repos/playbooks
    (cherry picked from commit 416407fbd59d3ab8729a9255e541e045a020d266)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1459986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants